On 2013-09-14 16:35:30, Philip Jägenstedt wrote:
This is useful so that the signer can see exactly what was sent
and makes it possible to resend/import/upload the signatures
later without signing again (risking duplicate signatures).
Thanks for the patch! Here's a quick review...
diff --git
This is useful so that the signer can see exactly what was sent
and makes it possible to resend/import/upload the signatures
later without signing again (risking duplicate signatures).
---
monkeysign/gpg.py | 13 -
monkeysign/ui.py | 17 +++--
2 files changed, 19
So, I'm not very happy at all with this patch, but want to discuss some of it.
Bits of it are fine, but the way that EmailFactory turned out is
pretty terrible, in particular the hack in cleanup_uids. I'm wondering
if things might become simpler if some of the logic is moved to the
outside of
3 matches
Mail list logo