Bug#724931: Please include the patch in git

2015-08-19 Thread adrian15
El 18/08/15 a las 19:28, Andreas Cadhalpun escribió: Hi adrian15, On 18.08.2015 10:47, adrian15 wrote: Can you please explain why you are using: get_fstype () function which it's based on blkid instead of just using the old method of relying in auto function from the kernel itself? The reas

Bug#724931: Please include the patch in git

2015-08-18 Thread Andreas Cadhalpun
Hi adrian15, On 18.08.2015 10:47, adrian15 wrote: > Can you please explain why you are using: get_fstype () function which it's > based > on blkid instead of just using the old method of relying in auto function > from the kernel itself? The reason is simply that 'mount -tauto' didn't work, whi

Bug#724931: Re: Bug#724931: Please include the patch in git

2015-08-18 Thread adrian15
El 08/03/14 a las 18:11, Andreas Cadhalpun escribió: I fixed a few things in my previous patch (see attachments): * Fix typo in finish-install.d/10apt-cdrom-setup: cdrom/$j -> cdrom$j * Always test for other CDs, except if it is a netinst CD. Otherwise one can't use CD-2 together with debi

Bug#724931: Please include the patch in git

2014-03-24 Thread Cyril Brulebois
Andreas Cadhalpun (2014-03-24): > Given that Bug #740673 is fixed and jessie alpha 1 is released, can > you review and upload these patches now? Let me be very clear: being pushy isn't going to get your stuff reviewed sooner (probably the contrary, in fact). Annoyed, KiBi. signature.asc Descri

Bug#724931: Please include the patch in git

2014-03-24 Thread Andreas Cadhalpun
Hi, On 08.03.2014 02:13, Cyril Brulebois wrote: Given the apt-cdrom regression we're hitting (#740673), I don't feel like shipping this amount of additional modifications in jessie alpha 1 images; Given that Bug #740673 is fixed and jessie alpha 1 is released, can you review and upload these

Bug#724931: Please include the patch in git

2014-03-14 Thread Cyril Brulebois
Cyril Brulebois (2014-03-08): > Given the apt-cdrom regression we're hitting (#740673), I don't feel > like shipping this amount of additional modifications in jessie alpha 1 > images; on the other hand, not uploading what's in apt-setup's master > currently would mean not using updated l10n mater

Bug#724931: Please include the patch in git

2014-03-08 Thread Cyril Brulebois
Andreas Cadhalpun (2014-03-08): > I looked more closely and found that commenting out the following in > 40cdrom fixes the problem: > # Allow apt-cdrom to manage mounting/unmounting CDs in /target > if [ "$cd_mountable" ]; then > rm -f $ROOT/etc/apt/apt.conf.d/00NoMountCD

Bug#724931: Please include the patch in git

2014-03-08 Thread Andreas Cadhalpun
Hi, On 08.03.2014 19:04, Cyril Brulebois wrote: Andreas Cadhalpun (2014-03-08): I generally agree that it would be good to have an alpha 1 installer to use for testing regressions of this patch, but on the other hand using loopmount to install Debian *works*. Sorry, but until it's been pushe

Bug#724931: Please include the patch in git

2014-03-08 Thread Cyril Brulebois
Andreas Cadhalpun (2014-03-08): > I generally agree that it would be good to have an alpha 1 installer > to use for testing regressions of this patch, but on the other hand > using loopmount to install Debian *works*. Sorry, but until it's been pushed to the masses, I can't blindly trust that. Ma

Bug#724931: Please include the patch in git

2014-03-08 Thread Andreas Cadhalpun
Hi, On 08.03.2014 02:13, Cyril Brulebois wrote: Given the apt-cdrom regression we're hitting (#740673), I don't feel like shipping this amount of additional modifications in jessie alpha 1 images; on the other hand, not uploading what's in apt-setup's master currently would mean not using update

Bug#724931: Please include the patch in git

2014-03-07 Thread Cyril Brulebois
Andreas Cadhalpun (2013-12-02): > On Topic: It's always better, if more people look at a patch, so I'd > be grateful for KiBi's thoughts on it, especially concerning the > effects for kFreeBSD, since I could not test these, because I did > not manage to unpack the initrd from the kFreeBSD ISO. Th

Bug#724931: Please include the patch in git

2013-12-03 Thread Andreas Cadhalpun
On 03.12.2013 00:46, Cyril Brulebois wrote: Andreas Cadhalpun (2013-12-02): this is now the second time that I did not get your mail. If you have any idea what could cause that, please let me know, because it is not really practical to always check bugs.debian.org. Gmail, spam folder? It's a

Bug#724931: Please include the patch in git

2013-12-02 Thread Cyril Brulebois
Andreas Cadhalpun (2013-12-02): > this is now the second time that I did not get your mail. If you > have any idea what could cause that, please let me know, because it > is not really practical to always check bugs.debian.org. Gmail, spam folder? It's a royal pain anyway since it believes it kno

Bug#724931: Please include the patch in git

2013-12-02 Thread Andreas Cadhalpun
Hi, this is now the second time that I did not get your mail. If you have any idea what could cause that, please let me know, because it is not really practical to always check bugs.debian.org. On Topic: It's always better, if more people look at a patch, so I'd be grateful for KiBi's though

Bug#724931: Please include the patch in git

2013-11-30 Thread Christian PERRIER
clone 724931 -1 reassign -1 debian-installer retitle -1 Please add needed modules for ISO loopmount to work in D-I thanks Quoting Andreas Cadhalpun (andreas.cadhal...@googlemail.com): > Hi, > > I have researched how to include the needed modules in the initrd. > > If I understand it correctly, i

Bug#724931: Please include the patch in git

2013-11-30 Thread Andreas Cadhalpun
Hi, I have researched how to include the needed modules in the initrd. If I understand it correctly, it would be possible to add the modules as dependencies of cdrom-detect. But that would not be feasible, because the kernel modules have the version of the kernel in their name and therefore th

Bug#724931: Please include the patch in git

2013-11-24 Thread Andreas Cadhalpun
Hi, On 24.11.2013 12:50, Christian PERRIER wrote: That (imho) won't work : if that module is not in D-I kernel then it should be added there. Why do you think this wouldn't work? The same stands here, but I suspect all these modules are already in D-I kernel image packages. Needs to be carefu

Bug#724931: Please include the patch in git

2013-11-24 Thread Christian PERRIER
clone 724931 -1 -2 -3 reassign -1 cdrom-detect reassign -2 hw-detect reassign -3 mountmedia thanks Quoting Andreas Cadhalpun (andreas.cadhal...@googlemail.com): > Hi, > > I just created patches against cdrom-detect-1.46, hw-detect-1.98 and > mountmedia-0.23. I hope that helps. > > For the patch

Bug#724931: Please include the patch in git

2013-11-24 Thread Andreas Cadhalpun
Hi, I just created patches against cdrom-detect-1.46, hw-detect-1.98 and mountmedia-0.23. I hope that helps. For the patch to work, the loop-module is needed in the initrd, so I suggest to make it a dependency of cdrom-detect. I furthermore highly recommend to make the ext4, ntfs and udf modul

Bug#724931: Please include the patch in git

2013-11-23 Thread Christian PERRIER
Quoting Andreas Cadhalpun (andreas.cadhal...@googlemail.com): > Hi, > > thanks for committing the patch to apt-setup [1]. > These changes have to be accompanied by the appropriate changes in > cdrom-detect (and vice versa), as otherwise the installer will not > work anymore. > Probably this should

Bug#724931: Please include the patch in git

2013-11-23 Thread Andreas Cadhalpun
Hi, thanks for committing the patch to apt-setup [1]. These changes have to be accompanied by the appropriate changes in cdrom-detect (and vice versa), as otherwise the installer will not work anymore. Probably this should be ensured with a versioned dependency. The changes in hw-detect and mo

Bug#724931: Please include the patch in git

2013-11-23 Thread Christian PERRIER
Quoting Andreas Cadhalpun (andreas.cadhal...@googlemail.com): > In general I think, that it would be good to include the patch now > and add any additional improvements later. I just committed the changes to apt-setup. I will probably soon upload the package with them . PLEASE TEST AS SOON AS POS

Bug#724931: Please include the patch in git

2013-11-01 Thread Christian PERRIER
Quoting Andreas Cadhalpun (andreas.cadhal...@googlemail.com): > I haven't heard from Ian since his last mail on 13th October and I > have no clue what he has in mind as a more general solution. Perhaps > he has been busy otherwise. > > In general I think, that it would be good to include the patc

Bug#724931: Please include the patch in git

2013-11-01 Thread Andreas Cadhalpun
Hi, I don't know why, but I didn't receive your email. I just read it on bugs.debian.org. Using the patched ISOs I noticed an error in the patch: In 41cdset $filename was incorrectly used instead of $ISOname. Therefore too many ISOs were considered as part of the set. The corrected patch is

Bug#724931: Please include the patch in git

2013-10-30 Thread Christian PERRIER
Quoting Andreas Cadhalpun (andreas.cadhal...@googlemail.com): > Control: affects -1 + hw-detect mountmedia > > Hi, > > the patch for this bug affects the following packages: > * apt-setup > * cdrom-detect > * hw-detect (check-missing-firmware) > * mountmedia > Since among the maintainers of a

Bug#724931: Please include the patch in git

2013-10-13 Thread Andreas Cadhalpun
Hi, On 13.10.2013 10:21, ian_br...@fastmail.net wrote: I'm not done with this yet. I'm working on a more general patch with new features, which will be forthcoming shortly. I would ask that nothing major be done until that is ready. I'm curious, what features do you want to add? "loopback" is

Bug#724931: Please include the patch in git

2013-10-13 Thread Ben Hutchings
On Sun, 2013-10-13 at 01:21 -0700, ian_br...@fastmail.net wrote: > On Sat, 12 Oct 2013 20:03:53 +0200 > Andreas Cadhalpun wrote: [...] > > For the patch to work, the loop-module is needed in the initrd, so I > > suggest to make it a dependency of cdrom-detect. I furthermore highly > > recommend to

Bug#724931: Please include the patch in git

2013-10-13 Thread ian_bruce
I'm not done with this yet. I'm working on a more general patch with new features, which will be forthcoming shortly. I would ask that nothing major be done until that is ready. The current version is certainly ready for testing, although Andreas already seems to have done so extensively. On Sat

Bug#724931: Please include the patch in git

2013-10-12 Thread Andreas Cadhalpun
Control: affects -1 + hw-detect mountmedia Hi, the patch for this bug affects the following packages: * apt-setup * cdrom-detect * hw-detect (check-missing-firmware) * mountmedia Since among the maintainers of all these packages is Christian Perrier, I'm sending this to you. A short summa