Package: free42-nologo Version: 1.4.77-1 Severity: important Tags: upstream patch Justification: fails to build from source
free42-nologo fails to build from source on mips and mipsel due to the usage of --hash-style=both. This option forces both sysv and gnu style hash in the resulting elf file. The gnu style has is not supported on mips and mipsel, as the format hasn't been designed with enough flexibility. Moreover this doesn't really make any sense to enable this option at the package level, it should be handled at the distribution level, which Debian does, by defaulting to --hash-style=both on architectures supporting it. This should therefore be removed from the Makefile. This is what the patch below does: --- a/debian/patches/hash-style-makefile.patch +++ b/debian/patches/hash-style-makefile.patch @@ -0,0 +1,18 @@ +Passing --hash-style=both, which means both sysv and gnu, doesn't make +sense a package level, it should be done at the distribution level by +changing the compiler defaults. Moreover it is not supported on all +architectures. + +--- a/gtk/Makefile ++++ b/gtk/Makefile +@@ -20,10 +20,6 @@ CXXFLAGS += -fPIC + LDFLAGS += -L/usr/X11R6/lib + LIBS := -lXmu -lX11 -lgtk-x11-2.0 -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lgobject-2.0 -lglib-2.0 + +-ifeq "$(shell uname -s)" "Linux" +-LDFLAGS += -Wl,--hash-style=both +-endif +- + SRCS = shell_main.cc shell_skin.cc skins.cc keymap.cc shell_loadimage.cc \ + shell_spool.cc core_main.cc core_commands1.cc core_commands2.cc \ + core_commands3.cc core_commands4.cc core_commands5.cc \ --- a/debian/patches/series +++ b/debian/patches/series @@ -1 +1,2 @@ fix-free42-makefile.patch +hash-style-makefile.patch -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: mips (mips64) Kernel: Linux 3.2.0-4-5kc-malta Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
