Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Hi Julian, I've read the bug history and I'm sending you the remaining patches one by one so that we don't end up in a total mess again. Sorry for that previous mess btw. I'm starting with what was patch 1/5 last year. Best, Michael -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lis

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Hi Julian, I'll need time for that because I've also lost track after all this time... ;-) Hopefully I'll manage this week. If not, it can be up to two months. Please give me a ping if it takes even longer... Best, Michael PS: Thanks for picking this up again. How about getting more main

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Sat, May 03, 2014 at 04:09:42PM +0200, Michael Schaller wrote: > Another friendly ping to Julian... > Julian, can you at least commit patch 4/5 as it fixes a docstring? Hi sorry, I'm busy most of the time, and should not work on it today either, but here I am: I committed the docstring patche

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Another friendly ping to Julian... Julian, can you at least commit patch 4/5 as it fixes a docstring? -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Friendly ping... -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

And I've sent the wrong patch. *sigh*I should call it a day...

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Oh. I just realized that there was an issue with patch 3.I'll send out a new version of the patch in a minute.

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Mon, Mar 10, 2014 at 8:28 PM, Michael Schaller wrote: > > On 03/10/2014 06:04 PM, Julian Andres Klode wrote: >> >> Cool. I commented on github. >> > Thank you for reviewing the patches. I've largely reworked the patches, > removed the changelog, updated the version, removed awkward stuff and ma

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On 03/10/2014 06:04 PM, Julian Andres Klode wrote: Cool. I commented on github. Thank you for reviewing the patches. I've largely reworked the patches, removed the changelog, updated the version, removed awkward stuff and made them simpler. Unfortunately now you have to review them all over

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Sat, Mar 08, 2014 at 01:04:35PM +0100, michael wrote: > And another friendly ping to Julian...I would really like to continue on this > one. ;-) > Cool. I commented on github. I do prefer patches by email for commenting, though. -- Julian Andres Klode - Debian Developer, Ubuntu Member See

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

And another friendly ping to Julian...I would really like to continue on this one. ;-)

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Friendly ping to Julian...

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Four more patches:https://github.com/michael-schaller/python-apt/commits/comp_type_deb The first commit includes Julian's preliminary CompTypeDeb patch and bumps the version to 0.9.3 in the changelog. Julian, please let me know what you think about these patches.

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Sat, 25 Jan 2014 17:17:18 +0100 Julian Andres Klode wrote I think I prefer something that uses properties if we only pass an apt_pkg.Dependency, like the following one; on the grounds that this is more common in apt.*. Julian, I've planned to rework this from i

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Sat, Jan 25, 2014 at 04:10:54PM +0100, michael wrote: > Those tests clearly look better! ^^ > When it comes to > https://github.com/michael-schaller/python-apt/commit/ef6202e2f54dc2085e4d87a01aa2a66ff7c1a437 > I would be already happy if you would include the updated docstring. The > rest is

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Those tests clearly look better! ^^ When it comes to https://github.com/michael-schaller/python-apt/commit/ef6202e2f54dc2085e4d87a01aa2a66ff7c1a437 I would be already happy if you would include the updated docstring. The rest is really just readability. ;-) What do you think of the second com

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Sat, Jan 25, 2014 at 12:41:14PM +0100, michael wrote: > Julian, did you see my reply on your > comment?https://github.com/michael-schaller/python-apt/commit/ef6202e2f54dc2085e4d87a01aa2a66ff7c1a437 > > > I'm not sure if GitHub sent you a notificaction... > Yes, but I'm happy with that part

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Julian, did you see my reply on your comment?https://github.com/michael-schaller/python-apt/commit/ef6202e2f54dc2085e4d87a01aa2a66ff7c1a437 I'm not sure if GitHub sent you a notificaction...

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Sat, Jan 18, 2014 at 5:31 PM, Michael Schaller wrote: I'll try to look at it this week, but university started again, so I'm more busy than before. Oh. Your studies keep you busy! No worries then. Take your time... ;-)

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Sat, Jan 18, 2014 at 5:31 PM, Michael Schaller wrote: > Friendly ping to to Julian. > I'll try to look at it this week, but university started again, so I'm more busy than before. -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Friendly ping to to Julian. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Before I start with the BaseDependency properties here two more proposals: apt/package.py: Improved readability and documentation of BaseDependency.__dstr(). https://github.com/michael-schaller/python-apt/commit/ef6202e2f54dc2085e4d87a01aa2a66ff7c1a437 apt/package.py: Simplified BaseDependency

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Julian, another question regarding this change... Do you have any problems with changing the constructor of apt.package.BaseDependency? I would like it to change it so that it only takes a apt_pkg.Dependency object as argument. As far as I see it the constructor is not documented and so I wou

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On 01/07/2014 02:33 PM, Julian Andres Klode wrote: Well, you can already start. I'm only missing stuff not relevant for you (tests & docs), so there's no problem if you go ahead and do the remaining stuff before I commit my part. Will do but that will most likely be on the weekend as my vacatio

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Mon, Jan 06, 2014 at 05:45:20PM +0100, Michael Schaller wrote: > > On 01/06/2014 05:35 PM, Julian Andres Klode wrote: > >It still needs test cases and documentation in doc, but should work. I > >thus did not commit it. > > > That looks good to me. Do you intend to submit it? > If so I can make

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On 01/06/2014 05:35 PM, Julian Andres Klode wrote: It still needs test cases and documentation in doc, but should work. I thus did not commit it. That looks good to me. Do you intend to submit it? If so I can make the needed apt_get.Dependency and apt.package.BaseDependency changes... It d

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Mon, Jan 06, 2014 at 04:56:27PM +0100, Michael Schaller wrote: > >If you think they are needed, go ahead. We have some other > >places using CompType() in the C++ code, though, and adding > >_deb variants for them would be complicated. > > > BaseDependency.relation_deb would only be a nice to ha

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On 01/06/2014 04:28 PM, Julian Andres Klode wrote: We do not support RPM. There was a fork apt-rpm but nobody ever merged it back. That's why I haven't heard of it in ages. ;-) If you think they are needed, go ahead. We have some other places using CompType() in the C++ code, though, and add

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Mon, Jan 06, 2014 at 03:43:25PM +0100, Michael Schaller wrote: > > On 01/06/2014 02:04 PM, Julian Andres Klode wrote: > >Outside the Debian world, the Debian style is not used. The style > >used here is just the common ASCII mathematical notation. > > Oh. Right! > Now that you mention it APT a

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On 01/06/2014 02:04 PM, Julian Andres Klode wrote: Outside the Debian world, the Debian style is not used. The style used here is just the common ASCII mathematical notation. Oh. Right! Now that you mention it APT also supports RPMs and thus it would make sense to use the math-notation. Got i

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Mon, Jan 06, 2014 at 12:31:52PM +0100, Michael Schaller wrote: > Having two styles explains totally why I'm confused. ^^ > Some more questions/comments regarding this... > > > What do you mean by "it uses the style everyone else uses"? > Isn't Debian-style THE common denominator? If not, do yo

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Having two styles explains totally why I'm confused. ^^ Some more questions/comments regarding this... What do you mean by "it uses the style everyone else uses"? Isn't Debian-style THE common denominator? If not, do you have a link where I can read more about the "style everyone else uses"? Ma

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Mon, Jan 06, 2014 at 08:09:43AM +0100, Michael Schaller wrote: > Awesome! My first patch in Debian. ^^ > Thanks for all your patience so far... > > Next thing on the agenda is the relation handling in BaseDependency. > I'm wondering if I'm the only one trying to use this but the > relation hand

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Awesome! My first patch in Debian. ^^ Thanks for all your patience so far... Next thing on the agenda is the relation handling in BaseDependency. I'm wondering if I'm the only one trying to use this but the relation handling seems to be totally broken at the moment. There is a huge difference

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Sun, Jan 05, 2014 at 07:15:05PM +0100, Julian Andres Klode wrote: > On Sat, Jan 04, 2014 at 07:08:58PM +0100, Michael Vogt wrote: > > Good catch, thanks! Updated that too. > > > > The patchset includes your pep8/pyflakes patch as well to avoid > > conflicts. Lets see if Julian has further feedb

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Sat, Jan 04, 2014 at 07:08:58PM +0100, Michael Vogt wrote: > Good catch, thanks! Updated that too. > > The patchset includes your pep8/pyflakes patch as well to avoid > conflicts. Lets see if Julian has further feedback and if he is also > ok with the changes I will commit to the python-apt git

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Tue, Dec 31, 2013 at 11:58:17PM +0100, Julian Andres Klode wrote: > On Tue, Dec 31, 2013 at 11:06:15PM +0100, Michael Vogt wrote: [..] > You really need to include the original copyright statement and the license > here, otherwise you violate the license. If the original code does not > include

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On 01/01/2014 05:44 PM, Michael Vogt wrote: On Wed, Jan 01, 2014 at 12:30:16PM +0100, Michael Schaller wrote: A few comments on the patches: Thanks for your review and the points you raised. You're welcome. I really like the idea to use Travis CI. 1) tests/test_pep8.py Can you document in

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Tue, Dec 31, 2013 at 11:04:47PM +0100, Julian Andres Klode wrote: > (Addressed to Michael Vogt, so don't wonder, other Michael...) [..] > I thought we wanted to use git-dch now (meaning after I released 0.9.1) for > changelog manipulation. I did commit 56ed099558a9f6e7137a8c113ca9efb2b2c1a1d2 >

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Wed, Jan 01, 2014 at 12:30:16PM +0100, Michael Schaller wrote: > A few comments on the patches: Thanks for your review and the points you raised. > 1) tests/test_pep8.py > Can you document in a comment or docstring why you ignore certain > issues and what these issues are? This should help rea

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

A few comments on the patches: 1) tests/test_pep8.py Can you document in a comment or docstring why you ignore certain issues and what these issues are? This should help readers to better understand what the test does and more importantly what it ignores. Furthermore do you plan to reduce the n

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On 12/31/2013 11:52 PM, Julian Andres Klode wrote: It's still a git patch, so it should still have a summary line. git tools are becoming a bit useless otherwise. I did not write “remove the summary line”. * apt/cache.py: - Fixed PEP8 issues - Fixed pyflakes issue: Removed unused local v

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Tue, Dec 31, 2013 at 11:06:15PM +0100, Michael Vogt wrote: > On Tue, Dec 31, 2013 at 01:09:39PM +0100, Michael Schaller wrote: [..] > It also adds a .travis.yml file that runs the tests. Next step is > to actually make the pep8/pylakes test to pass :) [..] That is now done, my branch is pyflake

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Tue, Dec 31, 2013 at 11:06:15PM +0100, Michael Vogt wrote: > From e751078fb9a532a3e8ef411e88d95adbe05ea0a5 Mon Sep 17 00:00:00 2001 > From: Michael Vogt > Date: Tue, 31 Dec 2013 21:36:26 +0100 > Subject: [PATCH 2/4] add pyflakes test > > --- > tests/test_pyflakes.py | 45 +

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Tue, Dec 31, 2013 at 11:40:34PM +0100, Michael Schaller wrote: > On 12/31/2013 10:23 PM, Michael Vogt wrote: > > Feel free to add yourself in the changelog, i.e. something like: > > + [ Michael Schaller ] > > Done. > > On 12/31/2013 11:00 PM, Julian Andres Klode wrote: > >It would be great if

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On 12/31/2013 10:23 PM, Michael Vogt wrote: > Feel free to add yourself in the changelog, i.e. something like: > + [ Michael Schaller ] Done. On 12/31/2013 11:00 PM, Julian Andres Klode wrote: It would be great if you could explain what the pyflakes issues were in a separate paragraph of the co

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

(Addressed to Michael Vogt, so don't wonder, other Michael...) On Tue, Dec 31, 2013 at 10:23:49PM +0100, Michael Vogt wrote: > On Tue, Dec 31, 2013 at 02:05:36PM +0100, Michael Schaller wrote: > > >You can just git-send-email them to the mailing list or even push a git > > >branch somewhere. > > >

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Tue, Dec 31, 2013 at 01:09:39PM +0100, Michael Schaller wrote: > Hi Michael, Hi Michael, > From my experience PEP8 and pyflakes are great tools with nearly no > false positives - especially compared to pylint - and by now they > are available for Python 2 and 3. Indeed, I tend to use this com

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Tue, Dec 31, 2013 at 02:05:36PM +0100, Michael Schaller wrote: > >You can just git-send-email them to the mailing list or even push a git > >branch somewhere. > > > Alrighty. Then let's stick to the bug for the time being as it > contains already the context for the patches. > > See attached th

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Tue, Dec 31, 2013 at 02:05:36PM +0100, Michael Schaller wrote: > >You can just git-send-email them to the mailing list or even push a git > >branch somewhere. > > > Alrighty. Then let's stick to the bug for the time being as it > contains already the context for the patches. > > See attached th

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

You can just git-send-email them to the mailing list or even push a git branch somewhere. Alrighty. Then let's stick to the bug for the time being as it contains already the context for the patches. See attached the patch with the PEP8 linter and pyflakes fixes. PEP8 only showed typical minor

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Hi Michael, From my experience PEP8 and pyflakes are great tools with nearly no false positives - especially compared to pylint - and by now they are available for Python 2 and 3. I personally like to add a lint command to setup.py to my projects. Maybe this would be beneficial for python-apt

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Tue, Dec 31, 2013 at 12:23:54PM +0100, Michael Schaller wrote: > Hi Julian, > > On 12/31/2013 01:29 AM, Julian Andres Klode wrote: > >On Sun, Dec 29, 2013 at 12:06:18PM +0100, Michael Schaller wrote: > >>Package: python-apt > >>Version: 0.9.2 > >>Severity: wishlist > >>Tags: patch > > > >This p

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Tue, Dec 31, 2013 at 01:29:53AM +0100, Julian Andres Klode wrote: > On Sun, Dec 29, 2013 at 12:06:18PM +0100, Michael Schaller wrote: [..] > > - Fixed PEP8 linter issues > > The PEP8 stuff should be separate. [..] Thanks for bringing up better pep8 compliance. I think something like the atta

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Hi Julian, On 12/31/2013 01:29 AM, Julian Andres Klode wrote: On Sun, Dec 29, 2013 at 12:06:18PM +0100, Michael Schaller wrote: Package: python-apt Version: 0.9.2 Severity: wishlist Tags: patch This patch does far too many things that are not even remotely connected. Fine by me. It's always

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

On Sun, Dec 29, 2013 at 12:06:18PM +0100, Michael Schaller wrote: > Package: python-apt > Version: 0.9.2 > Severity: wishlist > Tags: patch This patch does far too many things that are not even remotely connected. > >From 0d295006a98769cd6151c78b3a078ad92d8047ee Mon Sep 17 00:00:00 2001 > From: M

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Hi everyone, This is a feature request bug to improve the 'apt.package.Dependency' and 'apt.package.BaseDependency' classes in 'python-apt'. The current implementation of both classes is rather scarce and so I've refactored them to to include better properties. Most notably the information f

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies

Package: python-apt Version: 0.9.2 Severity: wishlist Tags: patch >From 0d295006a98769cd6151c78b3a078ad92d8047ee Mon Sep 17 00:00:00 2001 From: Michael Wisheu Date: Sun, 29 Dec 2013 11:57:19 +0100 Subject: [PATCH] * apt/cache.py: - Fixed PEP8 linter and pyflakes issues - Added 'InstalledFilter'