Source: quickfix
Version: 1.13.3+dfsg-8
Severity: important
Tags: patch
User: debian-h...@lists.debian.org
Usertags: hurd

Hi,

quickfix does not compile on GNU/Hurd [1].

The problem seems the same which appeared on kfreebsd-*, and that has
been solved in 1.13.3+dfsg-8 adding -pthread to the build flags.

Ideally a better solution would be using autoconf to detect the need
for cflags/ldlibs/etc for pthreads, but since the kfreebsd issue was
solved forcing -pthread in rules, I extended that for any non-Linux
architecture.

[1] 
https://buildd.debian.org/status/fetch.php?pkg=quickfix&arch=hurd-i386&ver=1.13.3%2Bdfsg-8&stamp=1397464672

Thanks,
-- 
Pino
--- a/debian/rules
+++ b/debian/rules
@@ -16,6 +16,7 @@ include /usr/share/quilt/quilt.make
 DEB_HOST_GNU_TYPE   ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
 DEB_BUILD_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
 DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH) 
+DEB_HOST_ARCH_OS ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
 ifneq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
 CROSS= --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE)
 else
@@ -33,10 +34,10 @@ CFLAGS += -O3 -msse3
 CXXFLAGS += -O3 -msse3
 endif
 
-# Fix FTBFS on kfreebsd-* builds, which require explicit pthread linkage
+# Fix FTBFS on !linux builds, which require explicit pthread linkage
 # Using CFLAGS/CXXFLAGS feels like an ugly hack, but no amount of coaxing with
 # DEB_LDFLAGS_MAINT_{PRE,AP}PEND seems to get the flag in the right position
-ifneq (,$(findstring kfreebsd,$(DEB_HOST_ARCH)))
+ifneq (linux,$(DEB_HOST_ARCH_OS))
 CFLAGS += -pthread
 CXXFLAGS += -pthread
 endif

Reply via email to