Bug#745963: rsnapshot: linux_lvm_cmd_lvremove is not silenced (lvcreate is)

[Julius Seemayer]

Package: rsnapshot
Version: 1.3.1-3
Severity: normal
Tags: patch

Hi,


rsnapshot   seems   to   be   wrongly   patched   at  one  point,   hence  the
linux_lvm_cmd_umount system() call is silenced,  but linux_lvm_cmd_lvremove is
not.   Since  only the latter is noisy by default (fix that,  lvm guys!),  the
wrong one is muted.

This applies for stable and sid, at least.

Patch:

--- /usr/bin/rsnapshot  2011-07-09 16:39:45.000000000 +0200
+++ rsnapshot   2014-04-26 20:34:12.000000000 +0200
@@ -3725,38 +3725,38 @@
             }
         }
 
         @cmd_stack = ();
         push(@cmd_stack, $config_vars{'linux_lvm_cmd_umount'});
 
         push(@cmd_stack, $config_vars{'linux_lvm_mountpath'});
         
         print_cmd(@cmd_stack);
         if (0 == $test) {
-            # silence gratuitous lvremove output
-            #$result = system(@cmd_stack);
-            $result = system(join " ", @cmd_stack, ">/dev/null");
+            $result = system(@cmd_stack);
             
             if ($result != 0) {
                 bail("Unmount LVM snapshot failed: $result");
             }
         }
 
         @cmd_stack = ();
         push(@cmd_stack, $config_vars{'linux_lvm_cmd_lvremove'});
 
         push(@cmd_stack, '--force');
         push(@cmd_stack, $linux_lvm_snapshotname);
         
         print_cmd(@cmd_stack);
         if (0 == $test) {
-            $result = system(@cmd_stack);
+            # silence gratuitous lvremove output
+            #$result = system(@cmd_stack);
+            $result = system(join " ", @cmd_stack, ">/dev/null");
             
             if ($result != 0) {
                 bail("Removal of LVM snapshot failed: $result");
             }
         }
     }
 }
 
 # accepts the name of the argument to split, and its value
 # the name is used for spitting out error messages

(note the "... lvremove output" comment,  which is obviously placed inside the
wrong if(0==$test){} scope)

Please  fix that,  right now I'd get cron mails for every single rsnapshot run
(without my patch applied).


Cheers,

        Julius


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org