Control: tags -1 +patch
Thanks for the new patch!
I've filed another bug on the PageUp/PageDown issue.
Greetings,
Daniel
On 24.08.2014 04:53, Olly Betts wrote:
Control: tags -1 +patch
On Sat, Aug 23, 2014 at 06:25:14PM +0200, Jakub Wilk wrote:
Alas, after applying this patch djvusmooth doesn't work well with
wxPython 3.0. I spotted two problems:
* The PageUp and PageDown cannot be used for switching between
pages. I partially fixed it by using wx.Notebooks instead of
wx.Choicebook[1]. But the keys still don't work when the focus is on
a TreeCtrl widget.
If you add a lot of bookmarks (lean on Ctrl+B for a bit), it becomes
clearer why - Page Up and Page Down are used by that control to scroll
up and down that list (and Home and End are also eaten).
We can add a handler for EVT_KEY_DOWN to steal these key presses back.
* Editing items in TreeCtrl widgets doesn't work.
I'm not sure why it doesn't just work (as wxPython/demo/TreeCtrl.py
from the wxPython 3.0 sources does and the code is very similar)
but adding a handler for EVT_RIGHT_CLICK which calls EditLabel()
makes it work as before.
If you have ideas how to fix any of these problems, I'm all ears.
:-) Unfortunately, I won't have much time to debug them myself.
I've attached a debdiff - this is against what's in unstable, using
the packaging from the SVN repo plus fixes for the two issues above.
You might need to similarly fix the other wx.TreeCtrl - the djvu file
I had to hand for testing had no text so I couldn't check that.
Cheers,
Olly
--
https://qa.debian.org/developer.php?login=debian%40danielstender.com
PGP key: 2048R/E41BD2D0
C879 5E41 1ED7 EE80 0F2E 7D0C DBDD 4D96 E41B D2D0
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
