Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-12-21 Thread Colin Watson
On Sun, Dec 20, 2015 at 02:30:50AM +0100, Michael Biebl wrote: > Am 14.11.2015 um 17:33 schrieb Michael Biebl: > > Hi Colin, I didn't receive any feedback on this patch yet. > > Would be great if you can have a look so we can fix this issue for good. > > Do you have any thoughts/concerns regarding

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-12-19 Thread Michael Biebl
Hi Colin, it's me again. Am 14.11.2015 um 17:33 schrieb Michael Biebl: > Hi Colin, I didn't receive any feedback on this patch yet. > Would be great if you can have a look so we can fix this issue for good. Do you have any thoughts/concerns regarding the proposed patch? If you don't find the pat

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-11-14 Thread Michael Biebl
On Thu, 10 Sep 2015 18:13:24 +0200 Michael Biebl wrote: > Hi Colin! > > On Tue, 12 May 2015 22:54:04 +0200 Michael Biebl wrote: > > Am 12.05.2015 um 17:42 schrieb Michael Biebl: > > > Am 12.05.2015 um 17:07 schrieb Michael Biebl: > > > > >> As you can see, systemd tries to repeatedly start the

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-09-10 Thread Michael Biebl
Hi Colin! On Tue, 12 May 2015 22:54:04 +0200 Michael Biebl wrote: > Am 12.05.2015 um 17:42 schrieb Michael Biebl: > > Am 12.05.2015 um 17:07 schrieb Michael Biebl: > > >> As you can see, systemd tries to repeatedly start the service until it hits > >> start-limit. > >> We should use sd_notify in

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-05-12 Thread Christoph Anton Mitterer
On Tue, 2015-05-12 at 13:45 +0200, Michael Biebl wrote: > (since this was targetted at me, you should have CCed me. I don't get > openssh-server bug mail) Sorry,... must have dropped out somehow. > A patch for that should be not that complicated and might even be worth > shipping downstream if up

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-05-12 Thread Michael Biebl
Am 12.05.2015 um 17:42 schrieb Michael Biebl: > Am 12.05.2015 um 17:07 schrieb Michael Biebl: >> As you can see, systemd tries to repeatedly start the service until it hits >> start-limit. >> We should use sd_notify in that case to pass a correct error code to systemd. > > Or we could use what's

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-05-12 Thread Michael Biebl
Am 12.05.2015 um 17:07 schrieb Michael Biebl: > root@pluto:~# echo foobar >> /etc/ssh/sshd_config > > root@pluto:~# systemctl restart ssh.service > Job for ssh.service failed. See 'systemctl status ssh.service' and > 'journalctl -xn' for details. > > root@pluto:~# systemctl status ssh.service

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-05-12 Thread Michael Biebl
Control: tags -1 + patch Am 12.05.2015 um 13:45 schrieb Michael Biebl: > On Mon, 30 Mar 2015 04:02:01 +0200 Christoph Anton Mitterer >> As for sd_notify,... a simply google query didn't turn up any existing >> patches for that and it may be hard to convince upstream to do it ;) > > A patch for th

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-05-12 Thread Michael Biebl
On Mon, 30 Mar 2015 04:02:01 +0200 Christoph Anton Mitterer wrote: > Hi Michael. (since this was targetted at me, you should have CCed me. I don't get openssh-server bug mail) > Your proposal seems to be a good solution for now. Maybe Colin can merge > it and it will find it's way into jessie.

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-03-29 Thread Michael Biebl
Am 30.03.2015 um 01:17 schrieb Michael Biebl: > So I suggest using the Type=forking option but also setting > RestartPreventExitStatus=255 [1], since 255 seems to be the return code > on config errors and I don't think it makes sense to restart in that case. > > The resulting ssh.service would loo

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-03-29 Thread Christoph Anton Mitterer
Hi Michael. Your proposal seems to be a good solution for now. Maybe Colin can merge it and it will find it's way into jessie. As for sd_notify,... a simply google query didn't turn up any existing patches for that and it may be hard to convince upstream to do it ;) Since this problem may affec

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-03-29 Thread Michael Biebl
Am 22.02.2015 um 19:45 schrieb Russ Allbery: > That's the problem with forking services that don't have status > notification. The default is Type=simple, which per systemd.service(5): > > If set to simple (the default value if neither Type= nor BusName= > are specified), it is expected t

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-02-22 Thread Russ Allbery
Colin Watson writes: > On Sun, Feb 22, 2015 at 06:09:28PM +0100, Christoph Anton Mitterer wrote: >> Well I'm a bit unsure... it practically fixes the problem, but a) It >> still doesn't catch any cases when sshd crashes for any other reason >> (and I think it should since systemd is also designed

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-02-22 Thread Christoph Anton Mitterer
On Sun, 2015-02-22 at 17:53 +, Colin Watson wrote: > Well, um, in either case, isn't it pretty weird that "systemctl status" > shows the unit as failed while the boot progress system shows it as OK? > Feels like a systemd bug to me. Arguably, I'mm CCing the systemd guys, perhaps they can help

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-02-22 Thread Colin Watson
On Sun, Feb 22, 2015 at 06:09:28PM +0100, Christoph Anton Mitterer wrote: > On Sun, 2015-02-22 at 11:46 +, Colin Watson wrote: > > Thanks. Do you think this would be suitable? It seems to have the > > right effect here. > > +ExecStartPre=/usr/sbin/sshd -t > > Well I'm a bit unsure... it pra

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-02-22 Thread Christoph Anton Mitterer
On Sun, 2015-02-22 at 11:46 +, Colin Watson wrote: > Thanks. Do you think this would be suitable? It seems to have the > right effect here. > +ExecStartPre=/usr/sbin/sshd -t Well I'm a bit unsure... it practically fixes the problem, but a) It still doesn't catch any cases when sshd crashes

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-02-22 Thread Colin Watson
On Sat, Feb 21, 2015 at 07:08:56PM +0100, Christoph Anton Mitterer wrote: > I've just tried that with systemd now,... starting the ssh service > there always yields in a success (status 0, green "OK"), even when > it actually failed to start. > > Simply add some invalid config option to sshd_confi

Bug#778913: openssh-server: init (at least systemd) doesn't notice when sshd fails to start and reports success

2015-02-21 Thread Christoph Anton Mitterer
Package: openssh-server Version: 1:6.7p1-3 Severity: important Hi. I've just tried that with systemd now,... starting the ssh service there always yields in a success (status 0, green "OK"), even when it actually failed to start. Simply add some invalid config option to sshd_config, restart and