The following patch seems to me to be a reasonable stab at fixing
the NULL pointer dereference.
Tested on Debian Jessie (amd64), against keys of type:
* dsa
* ecdsa
* ed25519
* rsa
* rsa1
On a valid key it shows the fingerprint. On my bogus sample it shows:
line 2
> .. and the exciting-looking address is apparently a typical load address
> for the ssh binary.
Yes. It was in the ascii-range, which made me more optimistic.
(I'm too used to using AAA..AAA as input and seeing 0x41. 0x55 looks
close enough to be plausible.)
Steve
--
I'm almost embarrassed to say that I submitted the wrong reproducer
in my original bug report.
The previous key does trigger the fault, but it is needlessly complex.
The attachment to this mail should be considered a saner example, as it
still triggers the crash, but it is is significantly
Package: openssh-client
Version: 1:6.7p1-5
Severity: important
Tags: security
Dear Maintainer,
I believe that the sanest way to generate an SSH fingerprint, for display
to users, etc, is via executing:
ssh-keygen -l -f path/to/public.key
This is the rationale behind the following blog-post:
4 matches
Mail list logo
