Bug#804069: apt-offline: Contains mbeded code copy -- AptOfflineMagicLib.py is actually magic.py from python-magic

2015-11-05 Thread Vasudev Kamath
Ritesh Raj Sarraf writes: > Hi Vasudev, > > Thanks for filing this bug report. While I understand the challenges of > carrying embedded copies, this is mainly does for convenience because > apt-offline has to run on other platforms too. Also different > variations of Linux

Bug#804069: apt-offline: Contains mbeded code copy -- AptOfflineMagicLib.py is actually magic.py from python-magic

2015-11-05 Thread Ritesh Raj Sarraf
On Thu, 2015-11-05 at 22:42 +0530, Ritesh Raj Sarraf wrote: > > I hope I've clarified myself. Install is used on Debian like system > > only > > which all provides same python-magic package. So why this code is > > still > > need to be embdedded? And I forgot to add the other potential consumers.

Bug#804069: apt-offline: Contains mbeded code copy -- AptOfflineMagicLib.py is actually magic.py from python-magic

2015-11-05 Thread Ritesh Raj Sarraf
On Thu, 2015-11-05 at 22:10 +0530, Vasudev Kamath wrote: > I understand your arguments. The actual python-magic provided by > src:file is not available from pypi, but where is it actually used?. > A > quick grep shows its only in *install* subcommand. Now where is > *install* command is supposed

Bug#804069: apt-offline: Contains mbeded code copy -- AptOfflineMagicLib.py is actually magic.py from python-magic

2015-11-04 Thread Vasudev Kamath
Package: apt-offline Version: 1.6.1 Severity: normal Hi, apt-offline contains embedded code copy of magic.py from python-magic, though file is renamed as AptOfflineMagicLib.py. I diffed this file against the latest version of magic.py from python-magic and there is no difference. I would

Bug#804069: apt-offline: Contains mbeded code copy -- AptOfflineMagicLib.py is actually magic.py from python-magic

2015-11-04 Thread Ritesh Raj Sarraf
Hi Vasudev, Thanks for filing this bug report. While I understand the challenges of carrying embedded copies, this is mainly does for convenience because apt-offline has to run on other platforms too. Also different variations of Linux distributions have different behavior and philosophy. On