Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-04-17 Thread Paul Gevers
Hi TheSin, On 04-04-16 20:56, TheSin wrote: > I just meant if mysql + php7 is used then you need to remove the > persist on the dsn, according to the adodb code base that is what > forces _pconnect with mysql driver, with mysqli persist is ignored. > > I just wanted to put that info incase it

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-04-04 Thread Paul Gevers
Hi TheSin, Your feedback is much appreciated. On 04-04-16 20:56, TheSin wrote: > I agree using mysqli will fix it without change. Great, that confirms my testing. > I just wanted to put that info incase it was an easier option then > trying to get everyone to update config to use mysqli. I to

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-04-04 Thread TheSin
I agree using mysqli will fix it without change. I just meant if mysql + php7 is used then you need to remove the persist on the dsn, according to the adodb code base that is what forces _pconnect with mysql driver, with mysqli persist is ignored. I just wanted to put that info incase it was

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-04-04 Thread Paul Gevers
Hi TheSin, On 04-04-16 18:46, TheSin wrote: > I believe the real issue isn’t with adodb, it’s line 38 of > /usr/share/cacti/site/lib/database.php Without any change except for database_type, my testing was already successful. Do you have any idea when and how this code would be triggered? >

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-04-04 Thread TheSin
I believe the real issue isn’t with adodb, it’s line 38 of /usr/share/cacti/site/lib/database.php $dsn = "$db_type://" . rawurlencode($user) . ":" . rawurlencode($pass) . "@" . rawurlencode($host) . "/" . rawurlencode($db_name) . "?persist”; I believe we must remove the persist, so it no

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-03-31 Thread Jean-Michel Vourgère
Control: reassign 815987 cacti Control: retitle 815987 cacti requires porting to php7.0; mysql removed Hello Paul > PHP Fatal error: Uncaught Error: Call to undefined function > mysql_pconnect() > (...) > Deprecated: mysql_pconnect(): The mysql extension is deprecated and > will be removed in

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-03-28 Thread Paul Gevers
Hi Jean-Michel, On 25-03-16 11:45, Jean-Michel Vourgère wrote: > Until a proper fix is released, can you patch your installed > adodb-mysqli.inc.php file, probably at > /usr/share/php/adodb/drivers/adodb-mysqli.inc.php, at line 121, replace > $this->port, > by > (int)$this->port, >

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-03-28 Thread Paul Gevers
Hi Damien, Thank you for taking the time to respond here. On 24-03-16 14:34, Damien Regad wrote: > As mentioned earlier, the 'mysql' driver is no longer available in PHP 7 > [2], you must use 'mysqli'. Good to know. So I understand correctly that because php doesn't support mysql driver

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-03-25 Thread Jean-Michel Vourgère
Hello Paul you wrote: >> I would try replacing >> $database_type = "mysql"; >> by >> $database_type = "mysqli"; >> maybe? >> >> *If* this work, cacti default driver should be changed too. A quick >> "grep -R database_type" in cacti source seems to show that there are >> many instances to

Bug#815987: [php-maint] Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-03-24 Thread Jean-Michel Vourgère
I just noticed that Nishanth Aravamudan from Canonical made a patch. https://patches.ubuntu.com/libp/libphp-adodb/libphp-adodb_5.20.3-1ubuntu1.patch I'm not sure having the .pc/ files in there is a good idea. But several changes look good for Debian. Upstream, you migh want the (int) cast on

Bug#815987: [php-maint] Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-03-24 Thread Damien Regad
Greetings, I'm the maintainer for ADOdb. I came here following an issue report [1] in our tracker. As mentioned earlier, the 'mysql' driver is no longer available in PHP 7 [2], you must use 'mysqli'. With regards to the error you're getting with the latter, I would appreciate if you could

Bug#815987: [php-maint] Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-02-26 Thread Paul Gevers
On 26-02-16 17:23, Ondřej Surý wrote: > http://adodb.org/dokuwiki/doku.php?id=project:version_5_development > > Highest PHP Version support (V5.21) 7 > > So I wouldn't worry too much and just wait for ADOdb 5.21 release. Depending on how serious adodb takes the mysql support in php7, this

Bug#815987: [php-maint] Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-02-26 Thread Ondřej Surý
http://adodb.org/dokuwiki/doku.php?id=project:version_5_development Highest PHP Version support (V5.21) 7 So I wouldn't worry too much and just wait for ADOdb 5.21 release. I can help with porting the packaging or just take a look at src:php-rrd or src:xdebug, how to do it efficiently. I

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-02-26 Thread Paul Gevers
Hi Jean-Michel, On 26-02-16 16:41, Jean-Michel Vourgère wrote: > I would try replacing > $database_type = "mysql"; > by > $database_type = "mysqli"; > maybe? > > *If* this work, cacti default driver should be changed too. A quick > "grep -R database_type" in cacti source seems to show that there

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-02-26 Thread Jean-Michel Vourgère
Paul Gevers wrote: > Please help me. I only include > "/usr/share/php/adodb/adodb.inc.php". Is that wrong? It looks like your configuration uses the deprecated mysql driver. That driver looks dead. You should be using mysqli, if I understand correctly. I would try replacing $database_type =

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-02-26 Thread Paul Gevers
[no need to mail me directly, I subscribed to the bug] On 26-02-16 16:01, Jean-Michel Vourgère wrote: > I believe you should not be using > /usr/share/php/adodb/drivers/adodb-mysql.inc.php. > /usr/share/php/adodb/drivers/adodb-mysqli.inc.php exists and probably is > what you want. > > Can you

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-02-26 Thread Jean-Michel Vourgère
Control: tags -1 + moreinfo Hello Paul I believe you should not be using /usr/share/php/adodb/drivers/adodb-mysql.inc.php. /usr/share/php/adodb/drivers/adodb-mysqli.inc.php exists and probably is what you want. Can you try replacing mysql by mysqli in your configuration file? Paul Gevers

Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

2016-02-26 Thread Paul Gevers
Package: libphp-adodb Version: 5.15-1 Severity: important -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 In response to the announcement¹ that strech will ship with php7.0 I tested my package cacti (which depends on libphp-adodb) with php7.0 in a clean sid lxc container. However, the error logs