Bug#825359: Aw: Re: Re: sbuild: unrealistic figure about total space used

2016-07-01 Thread Helge Deller
Hi Johannes, On 01.07.2016 17:06, Johannes Schauer wrote: > I refactored the whole function calculating the space and things should be > easier to understand now. > > If you want, you can try if sbuild from git still fixes your problem. Confirmed. I tested the sbuild from your git tree and it

Bug#825359: Aw: Re: Re: sbuild: unrealistic figure about total space used

2016-07-01 Thread Johannes Schauer
Hi, Quoting Johannes Schauer (2016-07-01 16:36:29) > The fix is in my local git now. In addition I will also prettify the code > there a bit more because I agree that use of these implicitly set variables > like $_ and $1 can become quite confusing and should be avoided. I refactored the whole

Bug#825359: Aw: Re: Re: sbuild: unrealistic figure about total space used

2016-07-01 Thread Johannes Schauer
Control: tag -1 + pending Quoting Helge Deller (2016-07-01 16:33:37) > > Can you confirm that my patch fixes the issue? > > Yes, confirmed. awesome! Thanks for helping find the problem! The fix is in my local git now. In addition I will also prettify the code there a bit more because I agree

Bug#825359: Aw: Re: Re: sbuild: unrealistic figure about total space used

2016-07-01 Thread Helge Deller
Hi Johannes, > I cannot test this but are you sure that the solution to this problem is not > instead this patch: Yes, it is. Just noticed that as well and wanted to send a new patch :-) > diff --git a/lib/Sbuild/Build.pm b/lib/Sbuild/Build.pm > index 6d36ec6..68c1f40 100644 > ---