Bug#827930: apt: Make apt-daily leverage the ConditionACPower feature of systemd

2016-06-23 Thread Nicolas Le Cam
2016-06-22 23:40 GMT+02:00 Nicolas Le Cam : > Historically, first time to fast exit, second time to check power > after the random wait (see commit e20d3bcf). > The random wait was moved to the timer unit (and the compatibility > cron job) but the two checks stayed. It did

Bug#827930: apt: Make apt-daily leverage the ConditionACPower feature of systemd

2016-06-22 Thread Nicolas Le Cam
Sorry, First patch was flawed, I've moved the check_power() function without seeing it was using debug_echo() internally. Fixed now. I've followed what was done when moving random_sleep() from the script to the cron job, i.e. remove calls to debug_echo(), see 14669d4b. Second patch has not been

Bug#827930: apt: Make apt-daily leverage the ConditionACPower feature of systemd

2016-06-22 Thread Nicolas Le Cam
2016-06-22 22:45 GMT+02:00 Julian Andres Klode : > The commit short description is a bit too long, can you shorten that > to about 70 characters? Sure done (for the second paragraph too). > I'm not sure why the cron job does the check 2 times, I'll have > to check that. >

Bug#827930: apt: Make apt-daily leverage the ConditionACPower feature of systemd

2016-06-22 Thread Julian Andres Klode
On Wed, Jun 22, 2016 at 10:45:52PM +0200, Julian Andres Klode wrote: > On Wed, Jun 22, 2016 at 10:27:19PM +0200, Nicolas LE CAM wrote: > > Package: apt > > Version: 1.2.13 > > Severity: normal > > Tags: patch > > > > Dear Maintainer, > > > > The rationnal for this is to be able to disable this

Bug#827930: apt: Make apt-daily leverage the ConditionACPower feature of systemd

2016-06-22 Thread Julian Andres Klode
On Wed, Jun 22, 2016 at 10:27:19PM +0200, Nicolas LE CAM wrote: > Package: apt > Version: 1.2.13 > Severity: normal > Tags: patch > > Dear Maintainer, > > The rationnal for this is to be able to disable this "feature" without > modifying package's script. My laptop has a pretty descent battery

Bug#827930: apt: Make apt-daily leverage the ConditionACPower feature of systemd

2016-06-22 Thread Nicolas LE CAM
Package: apt Version: 1.2.13 Severity: normal Tags: patch Dear Maintainer, The rationnal for this is to be able to disable this "feature" without modifying package's script. My laptop has a pretty descent battery and I prefer to keep automatic updates rather than saving a hundreth percent of