Bug#831390: static global variables are not thread safe

2016-07-15 Thread Maik Zumstrull
On 15 Jul 2016, at 15:49, Daniel Kahn Gillmor wrote: > > On Fri 2016-07-15 14:19:51 +0200, Maik Zumstrull wrote: >> As a quick fix, I suggest declaring these variables thread-local: >> >> static __thread FILE *groupsfile = NULL; >> static __thread FILE *shadowfile = NULL; >> static __thread FIL

Bug#831390: static global variables are not thread safe

2016-07-15 Thread Daniel Kahn Gillmor
On Fri 2016-07-15 14:19:51 +0200, Maik Zumstrull wrote: > Package: libnss-extrausers > Version: 0.6-3 > > The implementation uses three static global pointer variables: > > static FILE *groupsfile = NULL; > static FILE *shadowfile = NULL; > static FILE *usersfile = NULL; > > Since these are used wi

Bug#831390: static global variables are not thread safe

2016-07-15 Thread Maik Zumstrull
Package: libnss-extrausers Version: 0.6-3 The implementation uses three static global pointer variables: static FILE *groupsfile = NULL; static FILE *shadowfile = NULL; static FILE *usersfile = NULL; Since these are used without locks or atomic operations, this is not thread-safe, even though N