Bug#832368: Using of the meaningless fcntl()

2018-07-22 Thread Jose M Calhariz
On July 25, 2016 1:35:29 PM GMT+08:00, Hitoshi Ozeki wrote: >On Mon, 25 Jul 2016 03:33:14 +0900 I wrote: >> [wrong] fcntl(fd, F_SETFD, (long) 1); >> [correct] fcntl(fd, F_SETFD, FD_CLOEXEC); > >This "fcntl()" is used to clear the "close-on-exec flag." >I think that we should stop using t

Bug#832368: Using of the meaningless fcntl()

2016-07-24 Thread Hitoshi Ozeki
On Mon, 25 Jul 2016 03:33:14 +0900 I wrote: [wrong] fcntl(fd, F_SETFD, (long) 1); [correct] fcntl(fd, F_SETFD, FD_CLOEXEC); This "fcntl()" is used to clear the "close-on-exec flag." I think that we should stop using the meaningless "value 1". [wrong] fcntl(fd, F_SETFD, (long) 1); [co

Bug#832368: Using of the meaningless fcntl()

2016-07-24 Thread Hitoshi Ozeki
Package: at Version: 3.1.20-1 Severity: important Dear Maintainer, Please see this code. This is a part of daemon_setup() function in "daemon.c". daemon.c: line 204 /* We do NOT close fd, since we want to keep the lock. However, we don't * want to keep the