> This does work alright, but I actually like Chris' patch better, so I
> have swapped them.
:)
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
Chris, Boyang,
On Fr, 2016-08-05 at 17:09 +0200, Stephan Sürken wrote:
(...)
> > >
> > > (Did you see my patch?)
> > Really sorry I overlook the last several lines. It is a good
> > solution.
> hmm thanks ;). However, I already did a patch (actually before the
> bug
> popped up). It's already
Hi guys,
On Mi, 2016-08-03 at 23:46 +0800, Boyuan Yang wrote:
> 2016-08-03 23:34 GMT+08:00 Chris Lamb :
> >
> > I deliberately expand it immediately after command-line parsing to
> > avoid this.
> >
> > (Did you see my patch?)
> Really sorry I overlook the last several lines.
2016-08-03 23:34 GMT+08:00 Chris Lamb :
> I deliberately expand it immediately after command-line parsing to
> avoid this.
>
> (Did you see my patch?)
Really sorry I overlook the last several lines. It is a good solution.
Thanks,
Boyuan
> OK now I got your idea. That should be a good solution, but we may
> need to call os.path.expanduser() somewhere else.
I deliberately expand it immediately after command-line parsing to
avoid this.
(Did you see my patch?)
Regards,
--
,''`.
: :' : Chris Lamb
`. `'`
2016-08-03 22:50 GMT+08:00 Chris Lamb :
>> If we need to expand earlier or later, what is the difference between
>> current situation and patched version?
>
> With my patch, the manpage contains the string "~" instead of the
> value of the HOME environment variable. ie. it is
> If we need to expand earlier or later, what is the difference between
> current situation and patched version?
With my patch, the manpage contains the string "~" instead of the
value of the HOME environment variable. ie. it is reproducible.
Regards,
--
,''`.
: :' : Chris
2016-08-03 21:11 GMT+08:00 Chris Lamb :
>> The original author used os.getenv() in python argparse, so the output
>> of `mini-buildd --help' really depend on $HOME env var
>
> I agree that upstream are using an environment variable called HOME and
> note that it ends up in the
> The original author used os.getenv() in python argparse, so the output
> of `mini-buildd --help' really depend on $HOME env var
I agree that upstream are using an environment variable called HOME and
note that it ends up in the manpage.
However, this does not imply that the string "$HOME" will
Control: user reproducible-bui...@lists.alioth.debian.org
Control: usertags -1 environment
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org
2016-08-03 20:14 GMT+08:00 Chris Lamb :
> - default=os.getenv("HOME"),
> + default="$HOME",
>
> Unless I'm missing something, this
user reproducible-bui...@lists.alioth.debian.org
usertags 833340 timestamps
thanks
Hi,
> mini-buildd: please make the build reproducible
- default=os.getenv("HOME"),
+ default="$HOME",
Unless I'm missing something, this won't work as $VARS are not expanded
in Python..
(What you probably want
Source: mini-buildd
Version: 1.0.16
Severity: wishlist
Tags: patch
Hi,
The current unreproducible status is due to different env HOME value generated
by help2man.
An example patch is provided to fix make the package reproducible.
Thanks.
--- a/mini-buildd
+++ b/mini-buildd
@@ -77,9 +77,9 @@
12 matches
Mail list logo