On Thu 2016-08-04 18:40:52 -0400, Santiago Vila wrote:

> I finally did this:
>
> https://anonscm.debian.org/cgit/collab-maint/fwknop.git/commit/?id=b9d788bb5e58613e1c1400a684041d493b043510
> https://anonscm.debian.org/cgit/collab-maint/fwknop.git/commit/?id=48d2be65049e1fd03b0ea41a9e668edf2ca766c7
>
> because this is just a workaround.
>
> If time allows, will try to contact upstream about this oddity.

fwiw, fwknop actually only uses this value by passing it to
gpgme_set_engine_info() if the user hasn't explicitly asked for a
non-default value:

 https://sources.debian.net/src/fwknop/2.6.0-4/lib/gpgme_funcs.c/?hl=67#L63

But gpgme clearly automatically selects the preferred value if it is
passed NULL here:

 https://sources.debian.net/src/gpgme1.0/1.6.0-3/src/engine.c/?hl=368#L351

So the right upstream fix would be to strip out any hardcoded defaults
in fwknop, remove the configure.ac variable, and pass NULL to
gpgme_set_version_info() unless the user explicitly specifies otherwise.

hth,

    --dkg

Attachment: signature.asc
Description: PGP signature

Reply via email to