Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2017-04-15 Thread David Fifield
On Sat, Apr 15, 2017 at 08:20:56PM +0100, Chris Lamb wrote: > > bzip2: Firefox 52.0.1.dmg: trailing garbage after EOF ignored > > bzip2: Firefox 52.0.2.dmg: trailing garbage after EOF ignored > > Hm, that should already be fixed with > 21180c4b9f06ae967a77bee82df306058790fd98. You're

Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2017-04-15 Thread Chris Lamb
David Fifield wrote: > It is surprising to me that the error message refers to > TorBrowser.app/Contents/Resources/omni.ja That was the filename diffoscope was attempting to extract at the time of the error. > bzip2: Firefox 52.0.1.dmg: trailing garbage after EOF ignored > bzip2:

Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2017-04-15 Thread David Fifield
On Fri, Apr 14, 2017 at 11:00:50PM +0100, Chris Lamb wrote: > tags 833697 + pending > thanks > > Should be fixed in Git :) > > > https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=82fbe27785f08d3623073eb98a3a4670b02fd2dc I confirm that using

Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2017-04-14 Thread Chris Lamb
tags 833697 + pending thanks Should be fixed in Git :) https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=82fbe27785f08d3623073eb98a3a4670b02fd2dc Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-

Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2017-04-13 Thread David Fifield
On Thu, Apr 13, 2017 at 08:17:00AM +0100, Chris Lamb wrote: > Hi David, > > > diffoscope: libarchive.exception.ArchiveError when running on two dmg files > > Just looking into this. The original .dmg files now 404; could you upload > some new ones? :) I've just put the files back in place.

Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2017-04-13 Thread Chris Lamb
Hi David, > diffoscope: libarchive.exception.ArchiveError when running on two dmg files Just looking into this. The original .dmg files now 404; could you upload some new ones? :) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk

Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2016-08-29 Thread David Fifield
It seems that the error lies in the handling of the dmg layer. If I manually extract the dmg files using 7z from the p7zip-full package, then diffoscope doesn't crash. I.e., mkdir -p 20160806-6.5a1-965e0daa7d59{,-2}/m 7z x 20160806-6.5a1-965e0daa7d59/TorBrowser-6.5a1-osx64_en-US.dmg

Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2016-08-08 Thread Chris Lamb
> > It seems somewhat cumbersome to do in the code > > istr in some cases it prints the error and return false (so that a > "lower level" comparator can do the comparison This is, alas, done inconsistently. Some do it in ``recognizes` (returning False) and some do it in ``compare_details`` but

Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2016-08-08 Thread Mattia Rizzolo
On Mon, Aug 08, 2016 at 11:50:26AM +0200, Chris Lamb wrote: > Wider question: what's the general diffoscope policy on what to do when the > files are invalid? I don't this something like that was ever properly defined. > It seems somewhat cumbersome to do in the code, so I am > inferring that we

Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2016-08-08 Thread Chris Lamb
Hi, > diffoscope: libarchive.exception.ArchiveError when running on two dmg files ACK. Wider question: what's the general diffoscope policy on what to do when the files are invalid? It seems somewhat cumbersome to do in the code, so I am inferring that we just blow up in lots of cases we

Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2016-08-07 Thread David Fifield
Package: diffoscope Version: 56 Severity: normal I get a crash when running diffoscope on these two dmg files. They are just byproducts of a development process. The two files are here (about 65 MB each):