Hi everyone,

Thomas, thanks for your patch. I used it to build protobuf 3.0.2 for ubuntu
xenial, some remarks that might be of interest for the maintainers:

* The older GCC in Ubuntu does not accept
`-Wno-error=misleading-indentation` maybe this should be specified
conditional depending on the GCC version used?

* I had to add
```
set -e; \
export LD_LIBRARY_PATH=$(CURDIR)/src/.libs; \
```
online 49 in build/rules -> override_dh_auto_test-arch,
otherwise it would not find the protobuf library.

* I had to explicitly add `python3-six` as a build-dependency, not sure why
it did not get picked up by the automatic dependency management.

* The python3 tests have a bug in 3.0.2 and need this patch (
https://github.com/google/protobuf/commit/64958cdb1d68a0ddaf10bd0ebdb4c112c370c416
)
to pass successful.


-- 

met vriendelijke groet/kind regards,

Maarten Fonville

Reply via email to