Bug#840146: pbuilder: remove_packages checks for existence in host, not in chroot

2016-10-08 Thread James Clarke
Hi Thorsten, > On 8 Oct 2016, at 21:52, Thorsten Glaser wrote: > > James Clarke dixit: > >> I agree, this is bad. However, if this is only affecting sarge chroots, > > I never said that. That’s just where I noticed it. Ok, my bad, that's just how I read it. > Every time anything listed in REM

Bug#840146: pbuilder: remove_packages checks for existence in host, not in chroot

2016-10-08 Thread Thorsten Glaser
James Clarke dixit: >I agree, this is bad. However, if this is only affecting sarge chroots, I never said that. That’s just where I noticed it. Every time anything listed in REMOVEPACKAGES has a different state between the host system and the chroot, and when the chroot’s distro doesn’t actually

Bug#840146: pbuilder: remove_packages checks for existence in host, not in chroot

2016-10-08 Thread James Clarke
Control: found -1 0.224 Control: severity -1 important Hi Thorsten, > On 8 Oct 2016, at 21:20, Thorsten Glaser wrote: > > Package: pbuilder > Version: 0.226.1 > Severity: serious > Justification: breaks basic use > > The remove_packages function in pbuilder-modules contains: > >if (dpk

Bug#840146: pbuilder: remove_packages checks for existence in host, not in chroot

2016-10-08 Thread Thorsten Glaser
Package: pbuilder Version: 0.226.1 Severity: serious Justification: breaks basic use The remove_packages function in pbuilder-modules contains: if (dpkg -s "$pkg" 2>&1)>/dev/null ; then This obviously must be: if ($CHROOTEXEC dpkg -s "$pkg" 2>&1)>/dev/null ; then Because of thi