Package: dgit Version: 2.8 Severity: important Tags: patch Andrew Shadura writes to me in private email: > The error itself is: > > Use of uninitialized value $objid in hash element at /usr/bin/dgit line > 948, <GC> line 1. > > And the transcript can be found in the attachment.
Thanks to Andrew for the report and the transcript, the key part of which (helpfully run with -D) shows: splitbrain_pseudomerge... splitbrain_pseudomerge... Use of uninitialized value $objid in hash element at /usr/bin/dgit line 948, <GC> line 1. Looking at the code, it's obvious that it's broken. The check for `unless defined $archive_hash' in splitbrain_pseudomerge comes too late. And, there should be a test case for this. I think the attached patch (untested, as yet) will fix the underlying bug. I'm filing this bug report because I intend to allow 2.8 to migrate to testing. This bug is not a regression against 1.4 because 1.4 lacks the split brain feature entirely. So this bug will be in testing until an updated dgit (not yet uploaded) fixes it. Ian.
splitbrain-new.patch
Description: Binary data
-- Ian Jackson <ijack...@chiark.greenend.org.uk> These opinions are my own. If I emailed you from an address @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter.
