Package: valadoc
Version: 0.30.0~git20160518-1
Severity: important
Tags: patch upstream
Dear Maintainer,
Current valadoc version in testing and unstable fail to generate any
documentation with some perfectly valid input that used to work with
previous versions.
This is due to a change in upstream that started to use a buggy feature
of libgee-0.8. See upstream report at
https://bugzilla.gnome.org/show_bug.cgi?id=774653 for more details.
This bug affects for example libgsecuredelete package, that FTBFS in
testing and unstable because of that issue.
The ideal fix would be in libgee, but it is non-trivial to fix properly
in its side, and I think the current valadoc breakage here warrants at
least a temporary fix. The fix is fairly simple and harmless too, so
it shouldn't be too hard to make sure it doesn't cause any regressions.
See https://bugzilla.gnome.org/show_bug.cgi?id=774669 for the upstream
libgee bug report.
Regards,
Colomban
-- System Information:
Debian Release: stretch/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'),
(500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.7.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages valadoc depends on:
ii libc6 2.24-5
ii libcdt5 2.38.0-16
ii libcgraph6 2.38.0-16
ii libgee-0.8-2 0.18.1-1
ii libglib2.0-0 2.50.2-1
ii libgvc6 2.38.0-16
ii libvala-0.34-0 0.34.2-1
ii libvaladoc3 0.30.0~git20160518-1
valadoc recommends no packages.
Versions of packages valadoc suggests:
ii valac 0.34.2-1
-- no debconf information
>From 7505aff6d2621d57ffe547b3fccd2e59111e508e Mon Sep 17 00:00:00 2001
From: Colomban Wendling <b...@herbesfolles.org>
Date: Thu, 17 Nov 2016 23:26:08 +0100
Subject: [PATCH] Fix hiding some non-empty namespaces
---
src/libvaladoc/api/node.vala | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/libvaladoc/api/node.vala b/src/libvaladoc/api/node.vala
index 580828f..ff5fad9 100644
--- a/src/libvaladoc/api/node.vala
+++ b/src/libvaladoc/api/node.vala
@@ -176,7 +176,13 @@ public abstract class Valadoc.Api.Node : Item, Browsable, Documentation, Compara
* Specifies whether this node has at least one visible child
*/
public bool has_visible_children (Settings settings) {
- return has_visible_children_by_types (per_type_children.keys.to_array (), settings);
+ /* for some reason per_type_children.keys.to_array() returns rubbish */
+ foreach (NodeType type in per_type_children.keys) {
+ if (has_visible_children_by_type (type, settings)) {
+ return true;
+ }
+ }
+ return false;
}
/**
--
2.10.2
