Package: yaskkserv
Version: 1.1.0-1
Severity: grave

Dear Maintainer,

1. This version provide "yaskkserv.service", but missing Build-Depends
   "libsystemd-dev", need /usr/include/systemd/sd-daemon.h

   Thus this daemon does not provide the feature of systemd socket activation.

2. The "yaskkerv.service" provided this version depends
   "yaskkserv.socket". But "yaskkserv.socket" was not privided.

3. In systemd Unit file, we can't use shell expression.
   If you parse shell expression, use /bin/sh as follows:

      ExecStart=/bin/sh -c ". /etc/default/yaskkserv; exec 
/usr/sbin/$YASKKSERV_BIN --no-daemonize $DAEMON_OPTS $DIC_LIST"

Git format-patch attached.

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (90, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages yaskkserv depends on:
ii  libc6                2.24-5
ii  libgcc1              1:6.2.1-4
ii  libgnutls-openssl27  3.5.6-7
ii  libgnutls30          3.5.6-7
ii  libstdc++6           6.2.1-4
ii  lsb-base             9.20161101
ii  skkdic               20160507-1

Versions of packages yaskkserv recommends:
ii  skkdic-extra  20160507-1

yaskkserv suggests no packages.

-- Configuration Files:
/etc/default/yaskkserv changed:
YASKKSERV_BIN="yaskkserv_hairy"
SIMPLE_OPTS="--log-level=1 --max-connection=512 --port=1178"
NORMAL_OPTS="${SIMPLE_OPTS}"
HAIRY_OPTS="${NORMAL_OPTS} --server-completion-midasi-length=2048 
--server-completion-midasi-string-size=262144 --server-completion-test=1 
--google-japanese-input=notfound --google-japanese-input-timeout=1"
DAEMON_OPTS="${HAIRY_OPTS}"
LOCAL_DICS="\
/usr/local/share/skkdic/SKK-JISYO.chibutsu \
/usr/local/share/skkdic/SKK-JISYO.tanudic4 \
/usr/local/share/skkdic/SKK-JISYO.matsucon \
/usr/local/share/skkdic/SKK-JISYO.hatenakey
"
PKG_DICS="/etc/alternatives/SKK-JISYO \
SKK-JISYO.jinmei \
SKK-JISYO.geo \
SKK-JISYO.propernoun \
SKK-JISYO.not_wrong
"
DICS="${PKG_DICS} ${LOCAL_DICS}"
for DIC in ${DICS}
do
    DICBN=`basename $DIC`
    DIC_LIST="${DIC_LIST} /usr/share/yaskkserv/${DICBN}.yaskkserv"
done


-- no debconf information
From 6d87ebab1a1c18db30e81d3e62233b124fa376de Mon Sep 17 00:00:00 2001
From: Youhei SASAKI <uwab...@gfd-dennou.org>
Date: Mon, 21 Nov 2016 16:00:43 +0900
Subject: [PATCH] Fix systemd support

Signed-off-by: Youhei SASAKI <uwab...@gfd-dennou.org>
---
 debian/control           | 2 +-
 debian/rules             | 2 +-
 debian/yaskkserv.install | 1 +
 debian/yaskkserv.service | 3 +--
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/debian/control b/debian/control
index cb683ec..af2722d 100644
--- a/debian/control
+++ b/debian/control
@@ -4,7 +4,7 @@ Priority: extra
 Maintainer: KURASHIKI Satoru <lur...@gmail.com>
 Uploaders: Tatsuya Kinoshita <t...@debian.org>
 Homepage: http://umiushi.org/~wac/yaskkserv/
-Build-Depends: debhelper (>= 9), libgnutls28-dev
+Build-Depends: debhelper (>= 9.20160709~), libgnutls28-dev, libsystemd-dev
 Standards-Version: 3.9.8
 Vcs-Git: https://anonscm.debian.org/git/collab-maint/yaskkserv.git
 Vcs-Browser: https://anonscm.debian.org/git/collab-maint/yaskkserv.git
diff --git a/debian/rules b/debian/rules
index e5c6cc1..fb0dfb1 100755
--- a/debian/rules
+++ b/debian/rules
@@ -9,7 +9,7 @@ export DEB_LDFLAGS_MAINT_APPEND = -defs
 export DH_VERBOSE=1
 
 %:
-       dh $@
+       dh $@ --with systemd
 
 override_dh_auto_configure:
        ./configure --prefix=$(CURDIR)/debian/yaskkserv/usr --compiler=g++ 
--enable-google-japanese-input --enable-google-suggest
diff --git a/debian/yaskkserv.install b/debian/yaskkserv.install
index b8d1e0a..1654449 100644
--- a/debian/yaskkserv.install
+++ b/debian/yaskkserv.install
@@ -1 +1,2 @@
 debian/update-skkdic-yaskkserv usr/sbin
+debian/yaskkserv.socket        lib/systemd/system/
diff --git a/debian/yaskkserv.service b/debian/yaskkserv.service
index 543284e..41b19a4 100644
--- a/debian/yaskkserv.service
+++ b/debian/yaskkserv.service
@@ -5,8 +5,7 @@ Requires=yaskkserv.socket
 
 [Service]
 User=nobody
-EnvironmentFile=-/etc/default/yaskkserv
-ExecStart=/usr/sbin/${YASKKSERV_BIN} --no-daemonize ${DAEMON_OPTS} ${DIC_LIST}
+ExecStart=/bin/sh -c ". /etc/default/yaskkserv; exec /usr/sbin/$YASKKSERV_BIN 
--no-daemonize $DAEMON_OPTS $DIC_LIST"
 
 [Install]
 WantedBy=multi-user.target
-- 
2.10.2

Reply via email to