Chris,
вс, 15 янв. 2017 г. в 4:57, Chris Lamb :
> As it happens I wrote my own fix before I saw your email
> and I have pushed it — what do you think?
>
>
Making APK metadata appear at fixed place surely looks better. IMO, that
approach follows the original intent of the request much more closely
Hi Maria,
> Rewrote it so file ordering is not taken into account. Does it work now?
Yes, although this would still mean the output of diffoscope itself
is not determinstic. As it happens I wrote my own fix before I saw your email
and I have pushed it — what do you think?
Regards,
--
,'
Chris,
I see. Seems like file ordering differs for some reason. I should not have
relied on it, anyway.
Rewrote it so file ordering is not taken into account. Does it work now?
Thank you,
Maria
вс, 15 янв. 2017 г. в 2:43, Chris Lamb :
> Maria,
>
> Thank you so much for these :)
>
> > Added some
Maria,
Thank you so much for these :)
> Added some tests for APK comparator, see attached patch.
Unfortunately I'm seeing:
differences = [, , , ]
@skip_unless_tools_exist('apktool', 'zipinfo')
def test_android_manifest(differences):
> assert differences[1].source1 == 'AndroidMani
On Mon, 09 Jan 2017 17:11:39 + Chris Lamb wrote:
> Fixed - so sorry about that! Now I wonder if we should insist on tests
> with patches... ;)
Added some tests for APK comparator, see attached patch.
However, please keep in mind apktool takes a lot of time to run even on toy
examples, so addi
Hans-Christoph Steiner wrote:
> Thanks for your work on the APK diffing! I had to fix a typo to get it
> running that was introduced in diffoscope commit
Fixed - so sorry about that! Now I wonder if we should insist on tests
with patches... ;)
> With that change, diffoscope is now working for m
Thanks for your work on the APK diffing! I had to fix a typo to get it
running that was introduced in diffoscope commit
fe7ae15e1c177866acd478af4cc4a51bd5002017 at the bottom of it. It turned
'f_out' into a non-existent 'w'.
With that change, diffoscope is now working for me again. I'm running
7 matches
Mail list logo
