tags 851359 + pending
thanks
Chris Lamb wrote:
> Looks great, please go ahead and rebase onto the experimental
> branch :)
Looks pushed and the tests are passing, so marking as `pending`. Thanks
again!
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / ch
Hey Maria,
> […]
Looks great, please go ahead and rebase onto the experimental
branch :)
> > a) We should rename this global variable to something that reflects
> > this usage.
Thank for changing this. One thing I might fix up around here is that the
following code in main.py:
Confi
Hi Chris,
Thanks again for your guidance and help!
On 24.04.2017 19:13, Chris Lamb wrote:
> So, I think…
>
> if get_image_size(self.path) != get_image_size(other.path):
> raise AssertionError
>
> … are better written as:
>
> assert get_image_size(self.path) == get_image_size(othe
Hey Maria,
> I tried to improve indentation and other cosmetic things. What do you
> think of the current state?
Thanks for the quick updates :)
So, I think…
if get_image_size(self.path) != get_image_size(other.path):
raise AssertionError
… are better written as:
assert get_im
Hi Chris,
On 21.04.2017 22:58, Chris Lamb wrote:
> Hey Maria,
Thank you for looking into this!
> Some very quick thoughts:
> [...]
I tried to improve indentation and other cosmetic things. What do you
think of the current state?
Regarding Config().html_output -- I put the comment that should
Hey Maria,
> […]
This is _awesome_! For those who haven't tried this yet, take a look
at:
http://i.imgur.com/tLHNl5H.jpg
Some very quick thoughts:
- I don't quite follow what Config().html_output is used for (ie.
needs some comments, etc)
Perhaps this doesn't need to be a global but ra
Hi Chris!
> Could you push this to a branch so we can more easily play with it? :)
Pushed to siamezzze/image-visual-comparison . Thanks for your input!
Maria
signature.asc
Description: OpenPGP digital signature
Hey Maria,
> I believe the attached patch provides the requested feature.
Oh, awesome!
> I would be very grateful for any review or general advice on how to make
> it better.
Could you push this to a branch so we can more easily play with it? :)
Best wishes,
--
,''`.
: :' :
Hi,
I believe the attached patch provides the requested feature.
I would be very grateful for any review or general advice on how to make
it better.
From 7bdcf310284a11e788fe761f86b1d1dbb51cf968 Mon Sep 17 00:00:00 2001
From: Maria Glukhova
Date: Sat, 1 Apr 2017 22:07:54 +0300
Subject: [PATCH] Ad
On Mon, 26 Dec 2016 18:13:09 +0200 Emanuel Bronshtein wrote:
> 2. visual compare images in HTML output
> images can be shown using data URI:
>https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs
> The below tools can be used to detect difference in images:
>
10 matches
Mail list logo
