Bug#857121: biosig4c++ FTBFS on architectures where char is unsigned

2017-03-18 Thread John Paul Adrian Glaubitz
Control: tags -1 patch On 03/18/2017 07:54 AM, Alois Schloegl wrote: > -static const char STR_END[]={-1,'\0'}; > +static const char STR_END[]={(char)-1,'\0'}; > static char STR_NULL[]=" unspecified/unknown "; I'm not sure whether I like that patch because I would rather get rid of the out-of-ran

Bug#857121: biosig4c++ FTBFS on architectures where char is unsigned

2017-03-18 Thread Alois Schloegl
This bug was fixed upstream in commit 8e7c3d7e485e1d3af3f3094641282274424b7385 Attaches is the corresponding patch. Thanks for consideration, Alois commit 8e7c3d7e485e1d3af3f3094641282274424b7385 Author: Christoph Schmidt-Hieber Date: Sat Dec 10 16:50:41 2016 +0100 Fix compilation

Bug#857121: biosig4c++ FTBFS on architectures where char is unsigned

2017-03-08 Thread John Paul Adrian Glaubitz
So, this one is actually a bit tricky. The array in question is declared as t210/codes.h: static const char STR_END[]={-1,'\0'}; which is used in t210/scp-decode.cpp:2535, for example: strcat(temp_string,STR_END); Hence, STR_END is used as a string constant and therefore declaring STR_END as

Bug#857121: biosig4c++ FTBFS on architectures where char is unsigned

2017-03-08 Thread Adrian Bunk
Source: biosig4c++ Version: 1.3.0-2.1 Severity: serious https://buildd.debian.org/status/package.php?p=biosig4c%2B%2B&suite=sid ... gcc -c -pipe -fPIC -Wall -fno-builtin-memcmp -O2 -D=WITH_ZLIB -D=__4HAERTEL__ -D=WITH_FAMOS -D=WITH_CHOLMOD -D=WITHOUT_NETWORK -Wextra -I /usr/include/libxml2/ -