Package: dpkg-dev
Followup-For: Bug #872381
Hello.
It is good to see the main suggestion merged. Thanks!
You have not applied
0001-scripts-mk-stop-hard-coding-dpkg_datadir.patch
probably because you prefer the related parts in
f1175056 (build: Rework subst handling for built or installed
The attached version
fixes the spacing issue in tests with a more readable trick,
splits the changes inside tests into small chunks,
replaces - with _ in Make variable names,
avoids non portable -r -E sed options.
Without -r, sed in {buildflags,pkg-info}.mk should cause no
regression. It has
Hi!
On Mon, 2024-03-11 at 01:44:30 +0100, Nicolas Boulenguez wrote:
> Package: dpkg-dev
> Followup-For: Bug #872381
> Please consider this new patch queue instead of the old or untested
> ones. With this one applied on 279c6ccb, the package builds and
> passes all tests.
Thanks!
> *
Package: dpkg-dev
Followup-For: Bug #872381
Hello.
Please consider this new patch queue instead of the old or untested
ones. With this one applied on 279c6ccb, the package builds and
passes all tests.
* scripts/mk: only use ASCII characters
Cosmetic independent suggestion.
* scripts/mk:
Package: dpkg-dev
Followup-For: Bug #872381
This new version, based on c881a5a8,
* splits protection from double inclusion and dpkg_datadir generation
into separate commits
* fixes an error in DEB_BUILD_OPTION_PARALLEL
* removes a few dubious optimizations (like checking if dpkg_datadir
is
Package: dpkg-dev
Followup-For: Bug #872381
Hello.
The attached commits rebase the suggestions, take your answers into
account and slightly improved some style issues.
There may remain typos, nothing is tested this time.
>From d56d5af7fa1a01a581d0cc1901572ca9c407f538 Mon Sep 17 00:00:00 2001
-- stop hard-coding dpkg_datadir
> to avoid changing all pathname concatenation I changed dpkg_datadir to
> «$(patsubst %/,%,$(dir $(lastword $(MAKEFILE_LIST». But given that
> I think we might still need to substitute other things I've left this
> one out for now.
A rebased and slightly less
Hi!
Thanks for the updated patches! I've gone over these and merged
several of them, the others I've left out for now, as I wanted to
get the current release out, which has been dragging for too long
already while I was finalizing it.
On Sun, 2022-02-13 at 18:38:19 +0100, Nicolas Boulenguez
Package: dpkg-dev
Followup-For: Bug #872381
Of course,
-dpkg_datadir := $(shell $(dir $(lastword $(MAKEFILE_LIST
+dpkg_datadir := $(dir $(lastword $(MAKEFILE_LIST)))
Hello.
I have rebased the changes and taken your explanations into
account. This new patch queue is not tested again, but
> > [in scripts/mk/Makefile.am], I suggest to rename
> > scripts/mk/{default,buildtools}.mk to scripts/mk/*.mk.sed or similar
> > (for example, .sed.mk in order to keep syntax highlighting). Distinct
> > source and object files would also simplify scripts/mk/Makefile a lot.
> Yeah, that would be
Hi!
On Thu, 2022-02-10 at 21:53:59 +0100, Nicolas Boulenguez wrote:
> Package: dpkg-dev
> Followup-For: Bug #872381
> The --in-place sed option ([1]) may simplify scripts/mk/Makefile.am
> much more than the do_make_subst variable provided by
> build-aux/subst.am does. It is for now the only
Package: dpkg-dev
Followup-For: Bug #872381
(CCing Guillem as the author of the commits referenced below)
Hello.
The changes introduced by 1947fef8 and 981d5acb are basically
incompatible with the first patch in bug report #872381 [1].
For the record, commits a49f0a9c and f28cbcc4 also require
Package: dpkg-dev
Followup-For: Bug #872381
One more suggestion is attached.
>From 95a908b270a533fc5d4a58a45deb929ce0d6159e Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 1 Nov 2021 10:08:08 +0100
Subject: [PATCH 8/8] scripts/mk/buildopts.mk: small optimisations
Assign
Package: dpkg-dev
Version: 1.20.9
Followup-For: Bug #872381
The attached commits are, once more, manually rebased on the current
HEAD.
>From ad7a566e7966f7c8062a044d0c2df0b07b0011d7 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 29 Jul 2019 14:38:32 +0200
Subject: [PATCH 1/8]
Package: dpkg-dev
Followup-For: Bug #872381
The attached changes are split into smaller chunks and rebased on
55cdc52e. A merge conflict with 52166568 could have easily been
avoided, please review pending patches before reformatting comments.
>From f021e4d5ada4df39948afa339bd3a0859d28ed5a Mon
Please replace 0003.patch with the attached version (changes are
cosmetic but should use review and merge).
>From a93a87581dbe90bd15822f11f374ae6d76263ca4 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 29 Jul 2019 19:03:16 +0200
Subject: [PATCH 3 (v2)/3] scripts/mk: improve
Package: dpkg-dev
Version: 1.19.7
Followup-For: Bug #872381
Hello.
The attachments are commits based on the current git head (f0c3cccf).
2/ adds tests for the Make snippets.
The current implementation passes these new tests.
3/ implements the suggestion as a git commit.
It also passes all
Package: dpkg-dev
Version: 1.19.2
Followup-For: Bug #872381
Hi.
This new version improves the readability in various aspects,
and should be easyer to review.
It fixes a difference with the current version in dpkg-dev by
exporting all dpkg-architecture variables.
Is there anything that I can do to
Package: dpkg-dev
Version: 1.18.24
Severity: wishlist
Tags: patch
Hello.
A new implementation of
/usr/share/dpkg/architecture.mk
/usr/share/dpkg/buildflags.mk
/usr/share/dpkg/pkg-info.mk
is attached. You may use run_tests.sh to check that the behaviour
remains the same in most
19 matches
Mail list logo
