Bug#872577: debootstrap: Handle existing /dev

2018-02-22 Thread Geert Stappers
On Thu, Feb 22, 2018 at 06:26:32AM -0600, Dan Nicholson wrote: > On Wed, 22 Nov 2017 05:08:47 -0600 Dan Nicholson wrote: > > On Fri, Aug 25, 2017 at 4:07 PM -0600, Dan Nicholson > > > > > Ping? Patch is pretty straightforward, but I'd be happy to adjust any > > direction people like. > > Ping?

Bug#872577: debootstrap: Handle existing /dev

2018-02-22 Thread Dan Nicholson
On Wed, 22 Nov 2017 05:08:47 -0600 Dan Nicholson wrote: > On Fri, Aug 25, 2017 at 4:07 PM, Dan Nicholson > wrote: > > > On Tue, Aug 22, 2017 at 10:23 AM, Dan Nicholson > > wrote: > > > > > > That certainly helps, but it doesn't cover everything since the > > > mkdir's and ln's could fail. Those

Bug#872577: debootstrap: Handle existing /dev

2017-11-22 Thread Dan Nicholson
On Fri, Aug 25, 2017 at 4:07 PM, Dan Nicholson wrote: > On Tue, Aug 22, 2017 at 10:23 AM, Dan Nicholson > wrote: > > > > That certainly helps, but it doesn't cover everything since the > > mkdir's and ln's could fail. Those are easier to handle by adding -p > > and -f, respectively, but that's a

Bug#872577: debootstrap: Handle existing /dev

2017-08-25 Thread Dan Nicholson
On Tue, Aug 22, 2017 at 10:23 AM, Dan Nicholson wrote: > > That certainly helps, but it doesn't cover everything since the > mkdir's and ln's could fail. Those are easier to handle by adding -p > and -f, respectively, but that's a subtle change in behavior for ln > relative to the mknod change. In

Bug#872577: debootstrap: Handle existing /dev

2017-08-22 Thread Dan Nicholson
On Sun, Aug 20, 2017 at 4:57 PM, Philip Hands wrote: > Ben Hildred <426...@gmail.com> writes: > >> On Sun, Aug 20, 2017 at 3:25 AM, Ansgar Burchardt wrote: >> >>> Dan Nicholson writes: >>> > On Fri, Aug 18, 2017 at 2:48 PM, Henrique de Moraes Holschuh >>> > wrote: >>> >> Wouldn't it be more stra

Bug#872577: debootstrap: Handle existing /dev

2017-08-20 Thread Philip Hands
Ben Hildred <426...@gmail.com> writes: > On Sun, Aug 20, 2017 at 3:25 AM, Ansgar Burchardt wrote: > >> Dan Nicholson writes: >> > On Fri, Aug 18, 2017 at 2:48 PM, Henrique de Moraes Holschuh >> > wrote: >> >> Wouldn't it be more straigthforward to "test -e || mknod" ? >> > >> > I definitely cons

Bug#872577: debootstrap: Handle existing /dev

2017-08-20 Thread Ben Hildred
On Sun, Aug 20, 2017 at 3:25 AM, Ansgar Burchardt wrote: > Dan Nicholson writes: > > On Fri, Aug 18, 2017 at 2:48 PM, Henrique de Moraes Holschuh > > wrote: > >> Wouldn't it be more straigthforward to "test -e || mknod" ? > > > > I definitely considered that, but it seemed more noisy to the code

Bug#872577: debootstrap: Handle existing /dev

2017-08-20 Thread Ansgar Burchardt
Dan Nicholson writes: > On Fri, Aug 18, 2017 at 2:48 PM, Henrique de Moraes Holschuh > wrote: >> Wouldn't it be more straigthforward to "test -e || mknod" ? > > I definitely considered that, but it seemed more noisy to the code to > add a conditional for every call. But I'd be fine reworking to th

Bug#872577: debootstrap: Handle existing /dev

2017-08-18 Thread Dan Nicholson
On Fri, Aug 18, 2017 at 2:48 PM, Henrique de Moraes Holschuh wrote: > On Fri, 18 Aug 2017, Dan Nicholson wrote: >> When devices.tar.gz was being used, the devices would be written into >> place with tar. This has the effect that the devices would be merged >> into an existing /dev in the target. s

Bug#872577: debootstrap: Handle existing /dev

2017-08-18 Thread Henrique de Moraes Holschuh
On Fri, 18 Aug 2017, Dan Nicholson wrote: > When devices.tar.gz was being used, the devices would be written into > place with tar. This has the effect that the devices would be merged > into an existing /dev in the target. setup_devices_simple() does not > handle this case and fails when /dev alre

Bug#872577: debootstrap: Handle existing /dev

2017-08-18 Thread Dan Nicholson
Package: debootstrap Version: 1.0.89 Severity: normal Tags: patch When devices.tar.gz was being used, the devices would be written into place with tar. This has the effect that the devices would be merged into an existing /dev in the target. setup_devices_simple() does not handle this case and fai