Package: mupdf
Version: 1.11+ds1-1
Severity: minor
Tags: patch

Hi,

the provided mupdf.desktop is not completely valid (see also output
of `desktop-file-validate`).
The attached git-formatted patch fixes all the issues:
- drop 'Encoding' key, long deprecated
- drop 'Comment' key, as it duplicates the content of 'GenericName'
- drop 'application/x-pdf' from 'MimeType', since the canonical mimetype
  for PDF documents is 'application/pdf' (already listed)
- drop the action, since it is neither advertized by the 'Actions' key,
  nor valid (and it basically duplicates the desktop file itself)

Thanks,
-- 
Pino
>From 5d027ab179b313412dd22a19dff238f90fc09dd5 Mon Sep 17 00:00:00 2001
From: Pino Toscano <p...@debian.org>
Date: Thu, 28 Sep 2017 15:34:39 +0200
Subject: [PATCH] Make mupdf.desktop valid

- drop 'Encoding' key, long deprecated
- drop 'Comment' key, as it duplicates the content of 'GenericName'
- drop 'application/x-pdf' from 'MimeType', since the canonical mimetype
  for PDF documents is 'application/pdf' (already listed)
- drop the action, since it is neither advertized by the 'Actions' key,
  nor valid (and it basically duplicates the desktop file itself)
---
 debian/mupdf.desktop | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/debian/mupdf.desktop b/debian/mupdf.desktop
index 95a7e550..e33c4ea4 100644
--- a/debian/mupdf.desktop
+++ b/debian/mupdf.desktop
@@ -1,16 +1,11 @@
 [Desktop Entry]
-Encoding=UTF-8
 Name=MuPDF
 GenericName=PDF file viewer
-Comment=PDF file viewer
 Exec=mupdf %f
 TryExec=mupdf
 Icon=mupdf
 Terminal=false
 Type=Application
-MimeType=application/pdf;application/x-pdf;
+MimeType=application/pdf;
 Categories=Viewer;Graphics;
 NoDisplay=true
-
-[Desktop Action View]
-Exec=mupdf %f
-- 
2.14.2

Reply via email to