Bug#877512: slapd: enabled systemd integration (untested patch)

2023-06-29 Thread Ryan Tandy
On Wed, Jun 28, 2023 at 01:03:33PM -0700, Ryan Tandy wrote: SLAPD_CONF is also used (at least) by anyone who still uses a slapd.conf file instead of cn=config. Using -f or -F depending on what SLAPD_CONF points to was the main reason I assumed we'd need a wrapper script. But that could also be

Bug#877512: slapd: enabled systemd integration (untested patch)

2023-06-29 Thread Moritz Mühlenhoff
Am Wed, Jun 28, 2023 at 01:03:33PM -0700 schrieb Ryan Tandy: > Hmm. So on upgrade I suppose we would want to automatically migrate those > settings to a drop-in? That actually sounds doable; such a drop-in would > probably not have to be a conffile. Indeed, so my idea was that e.g. the systemd

Bug#877512: slapd: enabled systemd integration (untested patch)

2023-06-29 Thread Quanah Gibson-Mount
--On Thursday, June 29, 2023 12:27 PM +0200 Andreas Henriksson wrote: Feel free to file a bug upstream if you think the current configure.ac code needs adjustment. [...] It's my impression that configure.ac is missing a call to: PKG_PROG_PKG_CONFIG(0.29) Thus the PKG_CONFIG variable

Bug#877512: slapd: enabled systemd integration (untested patch)

2023-06-29 Thread Andreas Henriksson
Hello, On Wed, Jun 28, 2023 at 09:53:06AM -0700, Quanah Gibson-Mount wrote: > > > --On Wednesday, June 28, 2023 10:49 AM -0700 Ryan Tandy > wrote: > > > > > > TODO: For unknown reason configure seems to want to use > > > /usr/lib/systemd/system (rather than /lib/systemd/system) despite the

Bug#877512: slapd: enabled systemd integration (untested patch)

2023-06-28 Thread Quanah Gibson-Mount
--On Wednesday, June 28, 2023 2:03 PM -0700 Ryan Tandy wrote: Another (lower priority) thing I meant to look into is the sd_notify(3) support. Enabling that means changing the service type and adding the -d flag to stop slapd from detaching. Yep, you want -d 0 specifically. --Quanah

Bug#877512: slapd: enabled systemd integration (untested patch)

2023-06-28 Thread Ryan Tandy
On Wed, Jun 28, 2023 at 08:48:14PM +0200, Moritz Mühlenhoff wrote: OTOH, moving to the systemd unit might also be a good opportunity to reduce some complexity? Looking at slapd.default shipped with the current package SLAPD_SENTINEL_FILE, SLAPD_PIDFILE and SLAPD_NO_START are all settings which

Bug#877512: slapd: enabled systemd integration (untested patch)

2023-06-28 Thread Moritz Mühlenhoff
Am Wed, Jun 28, 2023 at 09:49:06AM -0700 schrieb Ryan Tandy: > On Wed, Jun 28, 2023 at 06:29:31PM +0200, Andreas Henriksson wrote: > > I'm attaching a patch which has only been compile-tested as I don't > > use slapd myself. It would be great if someone who uses slapd could > > pick it up, test it

Bug#877512: slapd: enabled systemd integration (untested patch)

2023-06-28 Thread Quanah Gibson-Mount
--On Wednesday, June 28, 2023 10:49 AM -0700 Ryan Tandy wrote: TODO: For unknown reason configure seems to want to use /usr/lib/systemd/system (rather than /lib/systemd/system) despite the precense of systemd.pc ... the configure script has hard-coded fallback paths... Thanks for

Bug#877512: slapd: enabled systemd integration (untested patch)

2023-06-28 Thread Ryan Tandy
On Wed, Jun 28, 2023 at 06:29:31PM +0200, Andreas Henriksson wrote: I'm attaching a patch which has only been compile-tested as I don't use slapd myself. It would be great if someone who uses slapd could pick it up, test it and finish the remaining work. Thanks for the patch and for doing the

Bug#877512: slapd: enabled systemd integration (untested patch)

2023-06-28 Thread Andreas Henriksson
Hello, I'm attaching a patch which has only been compile-tested as I don't use slapd myself. It would be great if someone who uses slapd could pick it up, test it and finish the remaining work. TODO: For unknown reason configure seems to want to use /usr/lib/systemd/system (rather than