Bug#879886: [Debian-med-packaging] libhts2: libhts2 needs to handle ABI changes

2017-11-07 Thread Diane Trout
Hi everyone, I talked some with upstream about the symbols issues with htslib2 https://github.com/samtools/htslib/issues/616 They think that cram/*.h are private headers, but because we have a policy of avoiding convenience copies we made those functions public[1] because a few applications

Bug#879886: [Debian-med-packaging] libhts2: libhts2 needs to handle ABI changes

2017-11-04 Thread Afif Elghraoui
على الجمعـة 3 تشرين الثاني 2017 ‫17:52، كتب Diane Trout: > There was also symbols removed between 1.4.1 to 1.5 but upstream didn't > change their SOVERSION. > > As an aside while I was looking at the missing symbols I found mfprintf > was still listed in htslib 1.5's cram/mFILE.h, but the

Bug#879886: [Debian-med-packaging] libhts2: libhts2 needs to handle ABI changes

2017-11-03 Thread Mattia Rizzolo
On Fri, Nov 03, 2017 at 02:52:11PM -0700, Diane Trout wrote: > I restored it with git-revert and rebuilt 1.4.1 and 1.5 and discovered > there were #MISSING# symbols in each rebuild That's at most to be expected, there was a SONAME bump in the meantime. > 1.2 -> 1.4.1 had missing symbols but

Bug#879886: [Debian-med-packaging] libhts2: libhts2 needs to handle ABI changes

2017-11-03 Thread Diane Trout
> I believe that adding the symbols file back in is the correct solution. > It should allow dpkg-shlibdeps to generate the correct libhst2 > dependencies version. > > Diane > > Graham pointed out there was a symbols file from 1.2 that was removed. I restored it with git-revert and rebuilt

Bug#879886: [Debian-med-packaging] libhts2: libhts2 needs to handle ABI changes

2017-11-03 Thread Diane Trout
> Would adding a symbols file back to the htslib packaging be an > alternative solution to manually overriding ${shlibs:Depends} in > samtools, bcftools, and python-pysam? The build-depends in these > packages are always versioned appropriately. > I believe that adding the symbols file back in

Bug#879886: [Debian-med-packaging] libhts2: libhts2 needs to handle ABI changes

2017-11-02 Thread Afif Elghraoui
على الجمعـة 27 تشرين الأول 2017 ‫09:55، كتب Mattia Rizzolo: > On Fri, Oct 27, 2017 at 12:52:31AM -0400, Afif Elghraoui wrote: [...] > > What would have been good to prevent the current breakage that has been > brought to my attention (samtools), what happened is that the newest > version of