Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-29 Thread Thomas Schmitt
Hi, i wrote: > > us.cdimage.debian.org is a quick one. Nicholas Geovanis wrote: > From which location? Germany? Ja. How about this final message in case that files are missing and that mismatching downloads were detected ? (The mismatches shown are fake and recorded twice to get more than 2.)

Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-29 Thread Nicholas Geovanis
On Fri, Dec 29, 2017 at 5:35 AM, Thomas Schmitt wrote: > I wrote: >> > > > sed -e 's/^[hH][tT][tT][pP]:\/\///' \ >> > > >... more -e for https, ftp, and file ... > > Philip Hands wrote: >> > > sed -e 's,^\(https\?\|ftp\|file\)://,,i' >> > > ... >> > > "

Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-29 Thread Thomas Schmitt
Hi, I wrote: > > > > sed -e 's/^[hH][tT][tT][pP]:\/\///' \ > > > >... more -e for https, ftp, and file ... Philip Hands wrote: > > > sed -e 's,^\(https\?\|ftp\|file\)://,,i' > > > ... > > > "$imageTmp/${url#[[:alpha:]]*://}" > > Are these widely porta

Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-29 Thread Philip Hands
On Thu, 28 Dec 2017, "Thomas Schmitt" wrote: > Hi, > > first a correction of my proposal: > > The else-case with > echo "WARNING: File not found after download:" >&2 > is not good. > It floods the log if one uses a mirror with few matching files. > Not finding a file after the download is a

Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-28 Thread Thomas Schmitt
Hi, first a correction of my proposal: The else-case with echo "WARNING: File not found after download:" >&2 is not good. It floods the log if one uses a mirror with few matching files. Not finding a file after the download is a normal situation. ---

Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-28 Thread Philip Hands
On Thu, 28 Dec 2017, "Thomas Schmitt" wrote: ... > Especially in need of attention: > > - I could not find a clear description how "wget" determines the local > file paths from URLs and option --directory-prefix="$imageTmp". > My current conversion from URL to path is purely heuristic therefor

Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-28 Thread Thomas Schmitt
Hi, i Cc: debian-cd with this follow-up to bug 884526 in the hope to get some review for the endeavor to detect damaged downloaded package files during a run of jigdo-lite. Some disputable aspects remain (plus a possible bug in current jigdo-lite, which will vanish by my proposal). I put them beh

Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-17 Thread Thomas Schmitt
Hi, Ouch. In jigdo-lite it is not easy to have the downloaded files verified with the checksums of the expected FileParts. Steve, i could need a decision in which direction i should go: - Check .jigdo MD5s by jigdo-lite. - Check by jigdo-file, with a new option --warn-unused-file to enable my

Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-17 Thread Thomas Schmitt
Hi, i identified a better candidate for detecting non-matching FilePart objects during scanning. (I learned that jigdo-lite downloads 10 files and then lets jigdo-file make a scan over the whole image in order to find the places where they fit. Is this done because jigdo-file has no idea of downlo

Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-16 Thread Thomas Schmitt
Hi, long live the netinst ISOs ! But my patch is not good. Much too many false positive messages. At least i now know that the program execution really gets through that code part. But obviously it does this not only with files which were actually downloaded. Also i learned that mfile->leafNa

Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-16 Thread Thomas Schmitt
Hi, if i shall place a bet, then i'd say the checksum mismatch in https://sources.debian.org/src/jigdo/0.7.3-5/src/mkimage.cc/#L508 is where the message should be issued: ... case JigdoDesc::MATCHED_FILE: { /* If file present in cache, copy its data to image, if

Bug#884526: jigdo-file: Does not report package rejections because checksum mismatch

2017-12-16 Thread Thomas Schmitt
Package: jigdo-file Version: 0.7.3-3+b2 Severity: normal Tags: upstream Dear Maintainer, the attempt to create debian-6.0.7-amd64-DVD-1.iso from http://cdimage.debian.org/cdimage/archive/6.0.7/amd64/jigdo-dvd/debian-6.0.7-amd64-DVD-1.jigdo and the default mirror http://ftp.de.debian.org/debian