Bug#887323: dewalls i386 test failure

2018-03-09 Thread Wookey
On 2018-03-09 19:24 +, Philip Schuchardt wrote: > Wow, we were using long doubles before. I don't think we need that much > precision for cave survey. In catch there is Approx() that should take care of > floating point comparison correctly. Yes. Catch has approx and margin and epsilon which

Bug#887323: dewalls i386 test failure

2018-03-09 Thread Philip Schuchardt
So we need to fixed the comparisons on the dewalls library. On Fri, Mar 9, 2018 at 2:24 PM Philip Schuchardt wrote: > Wow, we were using long doubles before. I don't think we need that much > precision for cave survey. In catch there is Approx() that should take care > of

Bug#887323: dewalls i386 test failure

2018-03-09 Thread Philip Schuchardt
Wow, we were using long doubles before. I don't think we need that much precision for cave survey. In catch there is Approx() that should take care of floating point comparison correctly. On Fri, Mar 9, 2018 at 11:30 AM Wookey wrote: > A bit of research tells that using

Bug#887323: dewalls i386 test failure

2018-03-09 Thread Wookey
A bit of research tells that using 'long double' causes 80-bit fp on x86 (i386 and amd64), as opposed to the 64-bit IEE 754 fp representation used on other platforms, which is what you get if you specify double. So I tried changing the angle.{cpp.h} code to use double instead of long double.

Bug#887323: dewalls i386 test failure

2018-03-09 Thread Wookey
On 2018-03-09 05:06 +, Wookey wrote: > > Changing the tests to this: > CHECK_THROWS( WallsSurveyParser("360.1").azimuth(Angle::Degrees) > ); > CHECK_THROWS( WallsSurveyParser("-0.1").azimuth(Angle::Degrees) ); > CHECK_THROWS( >

Bug#887323: dewalls i386 test failure

2018-03-08 Thread Wookey
Is this test actually right? Shouldn't it be Angle::Gradians? CHECK_THROWS( WallsSurveyParser("400g").azimuth(Angle::Degrees) ) same for; CHECK_THROWS( WallsSurveyParser("-0.1g").azimuth(Angle::Degrees) ); CHECK_THROWS(

Bug#887323: dewalls i386 test failure

2018-03-08 Thread Wookey
On 2018-01-31 20:59 +, Philip Schuchardt wrote: > Nice! I wonder if i386 don’t support exceptions properly or something... It's not that simple. I found out how to run specific tests with catch. There are two other groups of tests which are expected to throw and those work OK:

Bug#887323: dewalls i386 test failure

2018-01-31 Thread Philip Schuchardt
Nice! I wonder if i386 don’t support exceptions properly or something... On Tue, Jan 30, 2018 at 8:07 AM Wookey wrote: > On 2018-01-30 06:48 +, Philip Schuchardt wrote: > > I know I’ve been dragging my feet on this. Let’s see if I can figure > this out, > > this week. >

Bug#887323: dewalls i386 test failure

2018-01-30 Thread Wookey
On 2018-01-30 06:48 +, Philip Schuchardt wrote: > I know I’ve been dragging my feet on this. Let’s see if I can figure this out, > this week. I fished out an old netbook which is actually i386. And installed an unstable chroot on it (very slowly!) last night. Hopefully this will enable some