Bug#889066: lintian should warn if the maintainer scripts include "chown -R" or "chmod -R"

2018-02-06 Thread Daniel Kahn Gillmor
On Mon 2018-02-05 17:55:27 +0100, Raphael Hertzog wrote: > I'm not quite sure of what colord is vulnerable. #889060 assumes the > attacker can create arbitrary hardlinks as the "colord" user in > /var/lib/colord. I don't know colord enough to know if that's the case > and why that would be the case

Bug#889066: lintian should warn if the maintainer scripts include "chown -R" or "chmod -R"

2018-02-05 Thread Raphael Hertzog
Hi, On Fri, 02 Feb 2018, Chris Lamb wrote: > > In my case, I remember having touched many packages with dedicated > > users created and I expect this tag to have a very high false positive > > ratio > > Can you make this more concrete? (Or, perhaps, why is colord > vulnerable but your particular

Bug#889066: lintian should warn if the maintainer scripts include "chown -R" or "chmod -R"

2018-02-02 Thread Chris Lamb
[Splitting thread] > In my case, I remember having touched many packages with dedicated > users created and I expect this tag to have a very high false positive > ratio Can you make this more concrete? (Or, perhaps, why is colord vulnerable but your particular package is not..?) Regards, --

Bug#889066: lintian should warn if the maintainer scripts include "chown -R" or "chmod -R"

2018-02-02 Thread Chris Lamb
Hi Raphael, > Consensus? Has there been a broader discussion on this topic that I > missed? Chatter on #debian-devel mostly. > You could have a checklist I follow a checklist internally but, as I implied in my previous mail, using this particular tag is a poor example/representation. :) A quic

Bug#889066: lintian should warn if the maintainer scripts include "chown -R" or "chmod -R"

2018-02-02 Thread Raphael Hertzog
Hi, On Fri, 02 Feb 2018, Chris Lamb wrote: > > you do not suggest any alternative (how do I fix change > > permissions/ownership securely?) > > Indeed, as the consensus is still not clear at this point. Do you > have any suggestions for such a text? Consensus? Has there been a broader discussion

Bug#889066: lintian should warn if the maintainer scripts include "chown -R" or "chmod -R"

2018-02-02 Thread Chris Lamb
Raphael, > you do not suggest any alternative (how do I fix change > permissions/ownership securely?) Indeed, as the consensus is still not clear at this point. Do you have any suggestions for such a text? > Please try to be a bit more restrictive in what new tags you are > accepting. You seem

Bug#889066: lintian should warn if the maintainer scripts include "chown -R" or "chmod -R"

2018-02-02 Thread Raphael Hertzog
Hi, On Thu, 01 Feb 2018, Daniel Kahn Gillmor wrote: > "chown -R" and "chmod -R" are very hard to use safely Why ? > some debian maintainer scripts might be tempted to use them to adjust > file ownership to specific users. however, those scripts are > vulnerable to attack on kernels that do not

Bug#889066: lintian should warn if the maintainer scripts include "chown -R" or "chmod -R"

2018-02-02 Thread Chris Lamb
tags 889066 + pending thanks Fixed in Git, pending upload: https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=e46b47690c6018847c48e05d2162562f16bb87e6 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-

Bug#889066: lintian should warn if the maintainer scripts include "chown -R" or "chmod -R"

2018-02-01 Thread Daniel Kahn Gillmor
Package: lintian Version: 2.5.72 Severity: wishlist "chown -R" and "chmod -R" are very hard to use safely, and very tempting as a sledgehammer to "just make the permissions be what i want them to be". some debian maintainer scripts might be tempted to use them to adjust file ownership to specific