Bug#893731: [Piuparts-devel] Bug#893731: [piuparts] Please add docker support

2018-03-26 Thread Agustin Henze
On 03/25/18 10:41, Holger Levsen wrote: [...] def create_resolv_conf(self): +if settings.docker_image: +# Do nothing, docker already takes care of this +return >>> >>> and >>> def terminate_running_processes(self): +if

Bug#893731: [Piuparts-devel] Bug#893731: [piuparts] Please add docker support

2018-03-25 Thread Holger Levsen
On Sat, Mar 24, 2018 at 01:06:43PM -0300, Agustin Henze wrote: > >> - Use schroot session named SCHROOT-NAME for the chroot, instead of > >> building a new one with debootstrap. > >> + Use schroot session named SCHROOT-NAME for the testing environment. > > why drop the second half here? > Not re

Bug#893731: [Piuparts-devel] Bug#893731: [piuparts] Please add docker support

2018-03-25 Thread Holger Levsen
On Sun, Mar 25, 2018 at 12:50:08PM +0200, Andreas Beckmann wrote: > On 2018-03-24 17:06, Agustin Henze wrote: > > - help="Don't remove the temporary directory for the " > > + > > - "chroot when the program ends.") > > + help="Keep

Bug#893731: [Piuparts-devel] Bug#893731: [piuparts] Please add docker support

2018-03-24 Thread Agustin Henze
On 03/23/18 15:03, Holger Levsen wrote: [snip] > > I've done some review... > >> *--schroot*='SCHROOT-NAME':: >> - Use schroot session named SCHROOT-NAME for the chroot, instead of >> building a new one with debootstrap. >> + Use schroot session named SCHROOT-NAME for the testing environment.

Bug#893731: [Piuparts-devel] Bug#893731: [piuparts] Please add docker support

2018-03-23 Thread Holger Levsen
On Thu, Mar 22, 2018 at 09:36:46AM -0300, Agustin Henze wrote: > I have added doc for the new param and reworded some others :), please find > the > patches attached. I have pushed to the PR[0] as well because IMO it's easier > for doing review there. yep, many thanks, also for the updated/new p

Bug#893731: [Piuparts-devel] Bug#893731: [piuparts] Please add docker support

2018-03-22 Thread Agustin Henze
Hi h01ger, On 03/21/18 22:53, Holger Levsen wrote: [snip] >> The patch attached is made against origin/master. > > cool cool. Just one thing before I'm willing to merge this: please also > patch piuparts.1.txt to explain this new option. I have added doc for the new param and reworded some other

Bug#893731: [Piuparts-devel] Bug#893731: [piuparts] Please add docker support

2018-03-21 Thread Holger Levsen
Hi TiN, On Wed, Mar 21, 2018 at 05:32:32PM -0300, Agustin Henze wrote: > I have written a patch for adding docker support on piuparts. A new option is > introduced `--docker-image` e.g. > > $ piuparts --docker-image debian:unstable package.deb cool! > Honestly I didn't do too much testing on th