Control: tag -1 + pending Hi Tokkee and Barak,
Niko Tyni wrote: > > The package fails to build in a test rebuild on at least amd64 with > > gcc-8/g++-8, but succeeds to build with gcc-7/g++-7. The > > severity of this report will be raised before the buster release. > > There's an upstream patch for this at > > > https://github.com/octo/liboping/commit/18ca43507b351f339ff23062541ee8d58e813a53 I've prepared an NMU which includes this patch and fixes the FTBFS. Since there was no maintainer reaction at all, not even since the bug report became RC about two weeks ago, it should be eligble even for a zero-day NMU. But since I also added a debian/clean to be able to build the package twice in a row, I intend to upload it after this mail to DELAYED/2 to give yoiu some time to object to the NMU. Feel free to tell me if I should fast-forward the NMU and upload it directly. Full source debdiff: diff -Nru liboping-1.10.0/debian/changelog liboping-1.10.0/debian/changelog --- liboping-1.10.0/debian/changelog 2018-03-21 14:57:02.000000000 +0100 +++ liboping-1.10.0/debian/changelog 2018-07-31 22:15:09.000000000 +0200 @@ -1,3 +1,12 @@ +liboping (1.10.0-2.1) unstable; urgency=high + + * Non-maintainer upload. + * Apply upstream patch to fix FTBFS with GCC 8. (Closes: #897790) + * Create debian/clean with src/mans/*.[38] to be able to build twice in + a row. + + -- Axel Beckert <a...@debian.org> Tue, 31 Jul 2018 22:15:09 +0200 + liboping (1.10.0-2) unstable; urgency=medium * Bump policy diff -Nru liboping-1.10.0/debian/clean liboping-1.10.0/debian/clean --- liboping-1.10.0/debian/clean 1970-01-01 01:00:00.000000000 +0100 +++ liboping-1.10.0/debian/clean 2018-07-31 22:11:20.000000000 +0200 @@ -0,0 +1 @@ +src/mans/*.[38] diff -Nru liboping-1.10.0/debian/patches/cherry-pick_18ca4350_ping_host_add_Decrease_buffer_size_to_make_GCCs_truncation_check_happy.patch liboping-1.10.0/debian/patches/cherry-pick_18ca4350_ping_host_add_Decrease_buffer_size_to_make_GCCs_truncation_check_happy.patch --- liboping-1.10.0/debian/patches/cherry-pick_18ca4350_ping_host_add_Decrease_buffer_size_to_make_GCCs_truncation_check_happy.patch 1970-01-01 01:00:00.000000000 +0100 +++ liboping-1.10.0/debian/patches/cherry-pick_18ca4350_ping_host_add_Decrease_buffer_size_to_make_GCCs_truncation_check_happy.patch 2018-07-31 22:06:51.000000000 +0200 @@ -0,0 +1,21 @@ +Origin: commit 18ca43507b351f339ff23062541ee8d58e813a53 +Author: Florian Forster <f...@octo.it> +Bug: https://github.com/octo/liboping/issues/38 +Bug-Debian: https://bugs.debian.org/897790 +Description: ping_host_add: Decrease buffer size to make GCC's truncation check happy. + +--- a/src/liboping.c ++++ b/src/liboping.c +@@ -1605,10 +1605,8 @@ + } + else + { +- char errmsg[PING_ERRMSG_LEN]; +- +- snprintf (errmsg, PING_ERRMSG_LEN, "Unknown `ai_family': %i", ai_ptr->ai_family); +- errmsg[PING_ERRMSG_LEN - 1] = '\0'; ++ char errmsg[64]; ++ snprintf (errmsg, sizeof(errmsg), "Unknown `ai_family': %d", ai_ptr->ai_family); + + dprintf ("%s", errmsg); + ping_set_error (obj, "getaddrinfo", errmsg); diff -Nru liboping-1.10.0/debian/patches/series liboping-1.10.0/debian/patches/series --- liboping-1.10.0/debian/patches/series 2018-03-21 14:57:02.000000000 +0100 +++ liboping-1.10.0/debian/patches/series 2018-07-31 22:04:48.000000000 +0200 @@ -1,3 +1,4 @@ 0002-autoupdate-and-enable-automake-Wall.patch 0003-typo.patch debian-changes +cherry-pick_18ca4350_ping_host_add_Decrease_buffer_size_to_make_GCCs_truncation_check_happy.patch Regards, Axel -- ,''`. | Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
signature.asc
Description: Digital signature
