Bug#911157: lintian: complain about grepping the passwd/group file instead of using getent

2018-10-16 Thread Chris Lamb
Hi Rhonda, > ~\b(grep\b.*/etc/(?:passwd|group))\b > > I'm not completely sure about the syntax here, but the \b before the > bracket looks like it wouldn't catch egrep Oh, good catch. Fixed in: https://salsa.debian.org/lintian/lintian/commit/38b74fe0a101aa10d4ea87084fa05bc420986321 I

Bug#911157: lintian: complain about grepping the passwd/group file instead of using getent

2018-10-16 Thread Rhonda D'Vine
* Chris Lamb [2018-10-16 17:05:17 CEST]: > Dear Rhonda, > > Thank you for filing this. Sure, no worries. :) > > https://sources.debian.org/src/proftpd-dfsg/1.3.5d-1/debian/proftpd-basic.postinst/?hl=28#L28 > > is an example from our pool, but there are more. > > This example: > >

Bug#911157: lintian: complain about grepping the passwd/group file instead of using getent

2018-10-16 Thread Chris Lamb
tags 911157 + pending thanks Fixed in Git, pending upload: https://salsa.debian.org/lintian/lintian/commit/8cbfd096b018e384f905b198543aa90c107e22c6 checks/scripts.desc | 11 +++ data/scripts/maintainer-script-bad-command| 1 +

Bug#911157: lintian: complain about grepping the passwd/group file instead of using getent

2018-10-16 Thread Chris Lamb
Dear Rhonda, Thank you for filing this. > https://sources.debian.org/src/proftpd-dfsg/1.3.5d-1/debian/proftpd-basic.postinst/?hl=28#L28 > is an example from our pool, but there are more. This example: https://github.com/FRRouting/frr/blob/master/debianpkg/frr.postinst#L4-L9 … is also

Bug#911157: lintian: complain about grepping the passwd/group file instead of using getent

2018-10-16 Thread Rhonda D'Vine
Package: lintian Severity: wishlist Dear Maintainer, I was prodded by Lamby to file this bugreport. :) I noticed in a package (not yet in Debian) that it uses grep on the passwd/group file directly instead of using getent. This hinders detecting users stored in a different database. Given