Bug#911907: [monkeysphere] Bug#911907: monkeysphere: Patch v3

2018-10-30 Thread Daniel Kahn Gillmor
On Tue 2018-10-30 11:03:02 -0700, Sunil Mohan Adapa wrote: > We have been setting the TMPDIR to > /var/lib/monkeysphere/authentication/tmp/ in FreedomBox for some time > now to work around the problem. So, I think, in general, this solution > is fine. However, perhaps we could conservatively use

Bug#911907: [monkeysphere] Bug#911907: monkeysphere: Patch v3

2018-10-30 Thread Sunil Mohan Adapa
On Tuesday 30 October 2018 09:19 AM, Daniel Kahn Gillmor wrote: > On Mon 2018-10-29 12:56:48 -0700, Sunil Mohan Adapa wrote: >> Attached the patches do this with /usr/bin/env (better to have full >> path?). I have retested all invocations again. > > thanks! I've applied your patch on the master b

Bug#911907: monkeysphere: Patch v3

2018-10-30 Thread Daniel Kahn Gillmor
On Mon 2018-10-29 12:56:48 -0700, Sunil Mohan Adapa wrote: > Attached the patches do this with /usr/bin/env (better to have full > path?). I have retested all invocations again. thanks! I've applied your patch on the master branch upstream, and then also changed /usr/bin/env to just "env" -- no r

Bug#911907: monkeysphere: Patch v3

2018-10-29 Thread Sunil Mohan Adapa
On Monday 29 October 2018 11:50 AM, Sunil Mohan Adapa wrote: [...] > > I agree that it is better to not expose the environment to runuser. I > will make the change to use 'env' instead. Attached the patches do this with /usr/bin/env (better to have full path?). I have retested all invocations aga