Package: px
Version: 1.0.12-1
Severity: important

Hi!

I have found that px does not properly depend on packages it requires
at runtime. It misses at least a hard Depends on python3-pkg-resources
and procps. In a clean sbuild sid chroot:

(unstable-amd64-sbuild)root@angela:~# px
Traceback (most recent call last):
  File "/usr/bin/px", line 6, in <module>
    from pkg_resources import load_entry_point
ModuleNotFoundError: No module named 'pkg_resources'

Once python3-pkg-resources is installed by hand, I then get this:

(unstable-amd64-sbuild)root@angela:~# px
Traceback (most recent call last):
  File "/usr/bin/px", line 11, in <module>
    load_entry_point('pxpx==0.0.0', 'console_scripts', 'px')()
  File "/usr/lib/python3/dist-packages/px/px.py", line 92, in main
    procs = px_process.get_all()
  File "/usr/lib/python3/dist-packages/px/px_process.py", line 286, in get_all
    ps_lines = call_ps()
  File "/usr/lib/python3/dist-packages/px/px_process.py", line 169, in call_ps
    env=env)
  File "/usr/lib/python3.7/subprocess.py", line 769, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.7/subprocess.py", line 1516, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'ps': 'ps'

Finally, running `px <PID>` yields the following warning:

2018-11-23T16:37:16.688223: Now invoking lsof, this can take over a minute on a 
big system...
Can't list IPC / network sockets, make sure "lsof" is installed and in your 
$PATH

... which leads me to believe lsof could be in Recommends as well.

Great package, thanks for adding this to Debian! :)

-- System Information:
Debian Release: 9.6
  APT prefers stable
  APT policy: (500, 'stable'), (1, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages px depends on:
ii  python3           3.5.3-1
ii  python3-dateutil  2.5.3-2
ii  python3-docopt    0.6.2-1

px recommends no packages.

px suggests no packages.

Reply via email to