Package: git-buildpackage
Version: 0.9.11
Severity: normal

Hi,

As a result of the fix applied to gbp to fix #912426, gbp pq import can
no longer import patches containing no headers. This in turn causes dgit
to fail to clone at least glibc (where I originally saw this bug).

For example, running gbp pq import on glibc 2.28-2 gives:
> gbp:info: Trying to apply patches at 
> '56686caf41f17b97b32401a4b12ce45a22d80f37'
> gbp:warning: Patch 'git-updates.diff' has no authorship information, using 
> 'GNU Libc Maintainers <debian-gl...@lists.debian.org>'
> gbp:warning: Patch 'check-unknown-symbols.diff' has no authorship 
> information, using 'GNU Libc Maintainers <debian-gl...@lists.debian.org>'
> gbp:warning: Patch 'locale-print-LANGUAGE.diff' has no authorship 
> information, using 'GNU Libc Maintainers <debian-gl...@lists.debian.org>'
> gbp:warning: Patch 'LC_IDENTIFICATION-optional-fields.diff' has no authorship 
> information, using 'GNU Libc Maintainers <debian-gl...@lists.debian.org>'
> gbp:error: Failed to apply 
> '/home/jcowgill/me-workspace/glibc/glibc/debian/patches/localedata/local-all-no-archive.diff':
>  Failed to read patch header of 
> '/home/jcowgill/me-workspace/glibc/glibc/debian/patches/localedata/local-all-no-archive.diff':
>  b"error: empty patch: '/dev/null'\n"
> gbp:error: Couldn't apply patches

The first line of "local-all-no-archive.diff" is simply "---" to mark
that the patch contains no header. Since the above fix ignores anything
after encountering a "---", an empty file gets passed to git mailinfo
which barfs.

Reverting the fix from #912426 seems to fix this.

James

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to