Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-26 Thread Shengjing Zhu
On Tue, Jun 25, 2019 at 08:13:46PM +0200, Paul Gevers wrote: [...] > That said, I decided to unblock docker.io. > Thanks! But... you have a typo in the hint. The version should be 18.09.1+dfsg1-7.1. -- Shengjing Zhu signature.asc Description: PGP signature

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-25 Thread Arnaud Rebillout
On 6/25/19 2:08 AM, Paul Gevers wrote: > Hi Shengjing, > > On 24-06-2019 00:28, Shengjing Zhu wrote: >> Now, with good reason... >> >> It tooks me enough hours today to figure out why the tests crash the host(as >> described in #929662, running out of pids). >> >> The bug is not from upstream.

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-24 Thread Arnaud Rebillout
On 6/25/19 8:26 AM, Shengjing Zhu wrote: > >>> Well, after adding this func back, the tests run and the host doesn't >>> crash. >>> >>> However the tests still can't pass in schroot, the log says: >> [...] >> >>> Short version: these tests need privileged permission. >> And your schroot doesn't

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-24 Thread Arnaud Rebillout
On 6/23/19 5:09 PM, Paul Gevers wrote: > >> + * Non-maintainer upload. > This I worries me. Apparently Arnaud didn't consider it appropriate to > upload the patch and I don't see an ACK from any of the maintainers. In > my opinion, trying to save docker.io for buster isn't appropriate via a >

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-24 Thread Shengjing Zhu
On Mon, Jun 24, 2019 at 09:08:07PM +0200, Paul Gevers wrote: [...] > > The bug is not from upstream. Previously a file was removed from > > upstream tarball, named engine/pkg/chrootarchive/archive_test.go, which > > has an important init func: [...] > Are you saying this file is only needed for

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-24 Thread Paul Gevers
Hi Shengjing, On 24-06-2019 00:28, Shengjing Zhu wrote: > Now, with good reason... > > It tooks me enough hours today to figure out why the tests crash the host(as > described in #929662, running out of pids). > > The bug is not from upstream. Previously a file was removed from > upstream

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-23 Thread Shengjing Zhu
On Sun, Jun 23, 2019 at 09:11:46PM +0200, Paul Gevers wrote: > > All code could have bug, it includes the test code. If you find a > > serious bug for this version, please file a bug, then it could prevent > > docker.io to migrate. > > Oh, much simpler. If I won't let it migrate, I'll actively

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-23 Thread Shengjing Zhu
Now, with good reason... It tooks me enough hours today to figure out why the tests crash the host(as described in #929662, running out of pids). The bug is not from upstream. Previously a file was removed from upstream tarball, named engine/pkg/chrootarchive/archive_test.go, which has an

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-23 Thread Paul Gevers
Hi Shengjing, On 23-06-2019 13:59, Shengjing Zhu wrote: > On Sun, Jun 23, 2019 at 12:09:13PM +0200, Paul Gevers wrote: >> Technically, you're already too late, the package will only be 2 of 5 >> days old on Tuesday 13:00 UTC. But I have much worse concerns, see below. >> > > It's all up to the

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-23 Thread Sam Hartman
Regretfully, I was unable to validate my hypothesis. We really need better explanations about why skipping this test is appropriate. --Sam

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-23 Thread Sam Hartman
Hi, Paul. I can think of a number of cases why docker tests might be problematic in our build environment. I actually think that if these tests run in a VM but not in a build environment within a schroot, it's a fairly good sign that the tests are problematic the way we do builds. I'll try to do

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-23 Thread Shengjing Zhu
On Sun, Jun 23, 2019 at 12:09:13PM +0200, Paul Gevers wrote: > Technically, you're already too late, the package will only be 2 of 5 > days old on Tuesday 13:00 UTC. But I have much worse concerns, see below. > It's all up to the release team's decision, right? We already miss docker from last

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-23 Thread Paul Gevers
Control: tags -1 moreinfo Hi Shengjing, Arnaud, On 22-06-2019 22:14, Shengjing Zhu wrote: > Hi, > > On Tue, Jun 18, 2019 at 10:18:47PM +0200, Paul Gevers wrote: >> I don't like to rush you, but be aware that the time slot to fix this is >> closing. The package needs to be ready to migrate at

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-22 Thread Shengjing Zhu
Hi, On Tue, Jun 18, 2019 at 10:18:47PM +0200, Paul Gevers wrote: > I don't like to rush you, but be aware that the time slot to fix this is > closing. The package needs to be ready to migrate at 2019-06-25 13:00 > UTC [1]. If the package isn't ready, we'll remove it from buster (fixing > some

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-18 Thread Paul Gevers
Hi Arnaud, On 13-06-2019 10:46, Arnaud Rebillout wrote: >>> Or should I just stick to 18.09.1, and only upload a new debian version >>> that only includes the CVE fix? >> You'll get an unblock much easier. > > > I'll go this way then :) > I won't audit the whole 142 commits, even less convince

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-13 Thread Arnaud Rebillout
On 6/13/19 3:31 PM, Paul Gevers wrote: > Control: retitle -1 unblock: docker.io [pre-approval] > Control: tags -1 moreinfo > > Hi Arnaud, > > On 10-06-2019 06:44, Arnaud Rebillout wrote: >> I'm about to upload a fix for #929662 "docker.io: CVE-2018-15664", but >> before I do that I'd like to ask a

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-13 Thread Paul Gevers
Control: retitle -1 unblock: docker.io [pre-approval] Control: tags -1 moreinfo Hi Arnaud, On 10-06-2019 06:44, Arnaud Rebillout wrote: > I'm about to upload a fix for #929662 "docker.io: CVE-2018-15664", but > before I do that I'd like to ask a question to the release team. > > For now in

Bug#930293: unblock: docker.io/18.09.1+dfsg1-7

2019-06-09 Thread Arnaud Rebillout
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Hi, I'm about to upload a fix for #929662 "docker.io: CVE-2018-15664", but before I do that I'd like to ask a question to the release team. For now in testing we have docker.io 18.09.1,