Source: ataqv
Version: 1.1.1+ds-2
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0] we noticed that
ataqv could not be built reproducibly.
This is because it embedded the absolute build path when generating
a manual page:
│ │ │ │ │ \fB\-t\fR TEMPLATE_DIRECTORY, \fB\-\-template\-directory\fR
TEMPLATE_DIRECTORY
│ │ │ │ │ The location of the web app directory template.
│ │ │ │ │ (default:
│ │ │ │ │ -\fI\,/build/1st/ataqv\-1.1\/\fP.1+ds/src/scripts/src/web)
│ │ │ │ │ +\fI\,/build/2/ataqv\-1.1\/\fP.1+ds/2nd/src/scripts/src/web)
Patch attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible_build 1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible_build 2020-05-04 13:24:41.175047977 +0100
@@ -0,0 +1,25 @@
+Description: Make the build reproducible
+Author: Chris Lamb <la...@debian.org>
+Last-Update: 2020-05-04
+
+--- ataqv-1.1.1+ds.orig/src/scripts/mkarv
++++ ataqv-1.1.1+ds/src/scripts/mkarv
+@@ -285,7 +285,7 @@ def parse_arguments():
+ """each line contains a fragment length and count. It may """
+ ))
+
+- parser.add_argument('-t', '--template-directory',
default=locate_template_directory(sys.argv[0]), help=("""The location of the
web app directory template."""))
++ parser.add_argument('-t', '--template-directory', default='auto',
help=("""The location of the web app directory template."""))
+
+ parser.add_argument('-v', '--verbose', action='store_true', help='Talk
more.')
+ parser.add_argument('--version', action='version',
version=PROGRAM_VERSION)
+@@ -569,6 +569,9 @@ def write_metrics(indent, metrics):
+ if __name__ == '__main__':
+ args = parse_arguments()
+
++ if args.template_directory == 'auto':
++ args.template_directory = locate_template_directory(sys.argv[0])
++
+ loglevel = args.verbose and logging.DEBUG or logging.INFO
+ logging.basicConfig(level=loglevel, format=LOGGING_FORMAT)
+ logger = logging.getLogger(PROGRAM)
--- a/debian/patches/series 2020-05-04 13:17:44.926022545 +0100
--- b/debian/patches/series 2020-05-04 13:24:39.983021123 +0100
@@ -4,3 +4,4 @@
packaged_js
spelling
clean_less
+reproducible_build
