Hi,

I don't know perl at all, but looking through the sources, I found that
in Devscripts/Uscan/Downloader.pm, I think there's a function
'download' line 82 (the name 'sub' is probably for subroutine) :

- the start of the function is for http and ftp modes, until line 133
where I think it's for git mode (the comment explains the last 'else',
I suppose) ;

- in line 141, a gitrepo_dir variable gets assigned the name of the
future repository ;

- in line 145, I have no clue why there's a check on the mode being
'svn' : it's definitely not logical to have it there!

- in lines 150-154, a tarball is made (no need for a checkout, it
seems) ;

- in lines 155-168, a clone is made under various options, and lines
169-176, a tarball is made ;

- in lines 178-190, both previous blocks converge : the tarball is
compressed.

and.... we get out of download, leaving the checkout in place -- and I
think that's where some deletion should be added.


I'll probably be able to learn enough perl to propose a patch tomorrow;
it looks like a one-liner.

Cheers,

JP

Reply via email to