Bug#983868: gsequencer ftbfs with -Werror=maybe-uninitialized

2021-03-03 Thread Joël Krähemann
Hi all, There is a DEP3 patch in the repository. https://salsa.debian.org/multimedia-team/gsequencer/-/blob/master/debian/patches/patch-ags_midi_buffer_util-c.diff My opinion is you can pass NULL to these functions but actually you shouldn't do this. regards, Joël On Wed, Mar 3, 2021 at 10:45

Bug#983868: gsequencer ftbfs with -Werror=maybe-uninitialized

2021-03-03 Thread Mattia Rizzolo
On Wed, 3 Mar 2021, 10:30 am Joël Krähemann, wrote: > I am going to provide another tarball including this fix. > There is no need to stage this for bullseye, it can be fixed later. (Also because at this point it would require a release unblock...)

Bug#983868: gsequencer ftbfs with -Werror=maybe-uninitialized

2021-03-03 Thread Joël Krähemann
Hi, I just tested with gcc-9, the patch should fix the problems with ags_midi_buffer_util.c. I would call it a false positive, it is good that GCC complains but it doesn't actually know how a MIDI parser is implemented. If you need a higher-level API, I recommend you:

Bug#983868: gsequencer ftbfs with -Werror=maybe-uninitialized

2021-03-03 Thread Matthias Klose
Well, that's not what the GCC developers think. The warning is there in GCC 9 and GCC 11 as well. The name of the option even implies that this is a "maybe". Forcing it to become an error with -Werror might be wrong, so if you build with -Werrer, build with -Wno-error=maybe-uninitialized as

Bug#983868: gsequencer ftbfs with -Werror=maybe-uninitialized

2021-03-02 Thread Joël Krähemann
Hi, This is not a GSequencer bug! This behavior is wanted. delta_time was properly initialized in ags_midi_buffer_util_seek_message(). it would be wrong if delta_time was overridden by ags_midi_buffer_util_get_varlength(). it does only return 0 length so varlength shall not be set. If you

Bug#983868: gsequencer ftbfs with -Werror=maybe-uninitialized

2021-03-02 Thread Matthias Klose
Package: src:gsequencer Version: 3.7.38-1 Severity: important Tags: sid bullseye X-Debbugs-CC: Joël Krähemann gsequencer ftbfs with -Werror=maybe-uninitialized, with gcc-10 and gcc-11 from experimental. ags/audio/midi/ags_midi_buffer_util.c:2606:17: error: ‘current_delta_time’ may be used