Source: nn
Version: 6.7.3-14
Severity: normal
Tags: patch
Dear Maintainer,
>From c2266dc9bd7b7cf9d660a50c931c07258a6d47bd Mon Sep 17 00:00:00 2001
>From: Bjarni Ingi Gislason <bjarn...@rhi.hi.is>
>Date: Sun, 14 Mar 2021 00:48:02 +0000
>Subject: [PATCH] term.c: cast "lbuf" to "char *" in "CALL(completion) ()"
term.c:1932:26: warning: pointer targets in passing argument 1 of 'completion'
differ in signedness [-Wpointer-sign]
1932 | if (!CALL(completion) (lbuf, -(i + 1)) && did_help)
| ^~~~
| |
| key_type * {aka unsigned char *}
term.c:1932:26: note: expected 'char *' but argument is of type 'key_type *'
{aka 'unsigned char *'}
Signed-off-by: Bjarni Ingi Gislason <bjarn...@rhi.hi.is>
---
term.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/term.c b/term.c
index b756644..670f542 100644
--- a/term.c
+++ b/term.c
@@ -1929,7 +1929,7 @@ kill_prefill_hack:
tputc(BS);
clrline();
}
- if (!CALL(completion) (lbuf, -(i + 1)) && did_help)
+ if (!CALL(completion) ((char *) lbuf, -(i + 1)) && did_help)
clrmsg(i);
did_help = 0;
comp_len = comp_used = 0;
@@ -1941,7 +1941,7 @@ kill_prefill_hack:
if (!comp_used || c == comp2_key ||
(c == help_key && lastc != c)) {
lbuf[i] = NUL;
- if ((comp_used = CALL(completion) (lbuf, i)) == 0) {
+ if ((comp_used = CALL(completion) ((char *) lbuf, i)) == 0)
{
ding();
continue;
}
@@ -1993,7 +1993,7 @@ kill_prefill_hack:
}
}
if (comp_used) {
- if (!CALL(completion) (lbuf, -(i + 1)) && did_help)
+ if (!CALL(completion) ((char *) lbuf, -(i + 1)) && did_help)
clrmsg(i);
did_help = 0;
comp_len = comp_used = 0;
--
2.30.1
-- System Information:
Debian Release: bullseye/sid
APT prefers testing
APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.19-1 (SMP w/2 CPU threads)
Locale: LANG=is_IS.iso88591, LC_CTYPE=is_IS.iso88591 (charmap=ISO-8859-1),
LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
-- debconf information excluded
--
Bjarni I. Gislason
