Bug#844339: [PATCH v3 2/4] libvirt-daemon-system.{config,templates,postinst,NEWS}: warn if allocated uid/gid is taken

2016-11-29 Thread Mauricio Faria de Oliveira
Hi Guido, On 11/18/2016 05:43 PM, Mauricio Faria de Oliveira wrote: If you're OK w/ my suggestions, would you apply the guard snippet, or would prefer a v4 of this particular patch submitted? Did you have a chance to check this? Wondering how you'd prefer to continue with this one. Thanks!

Bug#844339: [PATCH v3 2/4] libvirt-daemon-system.{config,templates,postinst,NEWS}: warn if allocated uid/gid is taken

2016-11-18 Thread Mauricio Faria de Oliveira
Guido, On 11/18/2016 04:24 PM, Guido Günther wrote: I'm failing to spot how you make sure you only run on new installations. [snip] Oops. You're right. Not sure where my head was at. It passed tests due to debconf again; sorry. I thought of not doing a whole-file guard, but an early exit, to

Bug#844339: [PATCH v3 2/4] libvirt-daemon-system.{config,templates,postinst,NEWS}: warn if allocated uid/gid is taken

2016-11-18 Thread Guido Günther
Hi Mauricio, thanks! See my two inline comments below, we're nearing completion! On Fri, Nov 18, 2016 at 03:07:08PM -0200, Mauricio Faria de Oliveira wrote: > If the uid/gid that is allocated for libvirt-qemu (64055) > is already in use by another user/group, stop/ask user if > it is OK to

Bug#844339: [PATCH v3 2/4] libvirt-daemon-system.{config,templates,postinst,NEWS}: warn if allocated uid/gid is taken

2016-11-18 Thread Mauricio Faria de Oliveira
If the uid/gid that is allocated for libvirt-qemu (64055) is already in use by another user/group, stop/ask user if it is OK to continue (e.g., no plans with guest migration over NFS) or abort to go fix the problem. This warning is only displayed on new installations. The default value is