Bug#824903: letsencrypt.sh: Letsencrypt.sh broken due to "pretty" json used in Let's Encrypt API

2016-05-21 Thread Mattia Rizzolo 
control: found -1 0.1.0-2
control: notfound -1 0.1.0-2~bpo8+1
control: forwarded -1 https://github.com/lukas2511/letsencrypt.sh/pull/202

On Sat, May 21, 2016 at 06:34:41AM +0200, David Kuehling wrote:
> Version: 0.1.0-2~bpo8+1

> I'm testing this using the backports package, but I guess the problem
> applies to sid as well (same version).

Yeah, but, well, don't report bugs using the backport version.  The
Debian BTS does a version tracker, and it is not aware of the backports,
and fun things happens.

> Recently letsencrypt.org changed to return pretty json with lots of
> newlines (as tested via
> https://acme-staging.api.letsencrypt.org/directory).

I wonder when this happened and how.  Exactly yesterday I renewed some
certs of mine and the things just worked.

> This breaks
> various sed-based json parsing code in the distributed version of
> letsencrypt.sh .

Also I wonder if it would be better if letsencrypt.sh used jq(1) instead
of sed, but well..

>   https://github.com/lukas2511/letsencrypt.sh/pull/202
> 
> The "official" fix is here:
> 
>   
> https://github.com/lukas2511/letsencrypt.sh/commit/561f0626b855ec4ee94856884e2f1eff9ade2d88
> 
> cheers,

yeah, great, guess we can just cherry-pick it :)

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#824903: letsencrypt.sh: Letsencrypt.sh broken due to "pretty" json used in Let's Encrypt API

2016-05-20 Thread David Kuehling 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Package: letsencrypt.sh
Version: 0.1.0-2~bpo8+1
Severity: normal
File: /usr/bin/letsencrypt.sh

Hi,

I'm testing this using the backports package, but I guess the problem
applies to sid as well (same version).

Recently letsencrypt.org changed to return pretty json with lots of
newlines (as tested via
https://acme-staging.api.letsencrypt.org/directory).  This breaks
various sed-based json parsing code in the distributed version of
letsencrypt.sh .

The symptom is that 'letsencrypt.sh --cron' silently exits after
printing

  + Requesting challenge for 

Aborting before completing the challenge.

Looking at trace output from

   bash -x -c 'source /usr/bin/letsencrypt.sh --cron'

It obviously fails to extract the challenge from json output due to

  sed -n 's/.*\("challenges":[^\[]*\[[^]]*]\).*/\1/p'

expecting the hole match to be on a single line.  Somebody reported the
issue upstream on May 18th:

  https://github.com/lukas2511/letsencrypt.sh/pull/202

The "official" fix is here:

  
https://github.com/lukas2511/letsencrypt.sh/commit/561f0626b855ec4ee94856884e2f1eff9ade2d88

cheers,

David

- -- System Information:
Debian Release: 8.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages letsencrypt.sh depends on:
ii  curl 7.38.0-4+deb8u3
ii  openssl  1.0.1k-3+deb8u5

letsencrypt.sh recommends no packages.

letsencrypt.sh suggests no packages.

- -- no debconf information

- -- 
GnuPG public key: http://dvdkhlng.users.sourceforge.net/dk2.gpg
Fingerprint: B63B 6AF2 4EEB F033 46F7  7F1D 935E 6F08 E457 205F

-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iF4EAREIAAYFAlc/5WIACgkQk15vCORXIF+G/gD/YYZYGZDLM6Jb64JCtWojJCqP
dLaNFWQkMUqrfuizXJkBAKmJjaUMs8PHREkge9T1oIjVzukCQA7dz9Y2OndEAxIx
=nAa2
-END PGP SIGNATURE-