One small point: I think it might be better to pass 8 for bitmap_pad
rather than g_bpp... which should have the same effect of specifying no
padding, but is in line with X11 documentation which specifies that you
should pass 8, 16 or 32 for bitmap_pad. I'm a little worried that some
future X
Pierre,
The existing write_error() function prints an error, removes the output
file and exits with an error code. So I believe that my patch is
equivalent to what you are suggesting (except you have some unreachable
code :)).
Matt
On Sat, Jun 03, 2006 at 12:29:37PM +0200, Pierre HABOUZIT
Package: gzip
Version: 1.3.5-13
Severity: critical
Tags: patch
Justification: causes serious data loss
gzip must check that closing the output file succeeds before removing
the input file, since on an NFS filesystem write failures may only be
reported at close time (see the close(2) man page).
3 matches
Mail list logo
