Your message dated Sun, 28 Nov 2021 02:48:31 +0000
with message-id <e1mraex-0003sq...@fasolo.debian.org>
and subject line Bug#1000204: fixed in pyfai 0.20.0+dfsg1-4.1
has caused the Debian Bug report #1000204,
regarding pyfai: FTBFS if built using python3.10 (collections.MutableSets
deprecated)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1000204: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000204
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: pyfai
Version: 0.20.0+dfsg1-4
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu jammy ubuntu-patch
X-Debbugs-Cc: sl...@ubuntu.com
Dear Maintainer,
collections.MutableSet was deprecated a long time ago and removed with
python3.10.
https://docs.python.org/3/whatsnew/3.10.html#removed
https://bugs.python.org/issue37324
Using the old class name leads to autopkgtest failures such as this one:
```
======================================================================
ERROR: test_import_all_modules
(pyFAI.test.test_bug_regression.TestBugRegression)
Try to import every single module in the package
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/<<BUILDDIR>>/pyfai-0.20.0+dfsg1/.pybuild/cpython3_3.10_pyfai/build/pyFAI/test/test_bug_regression.py",
line 286, in test_import_all_modules
raise err
File
"/<<BUILDDIR>>/pyfai-0.20.0+dfsg1/.pybuild/cpython3_3.10_pyfai/build/pyFAI/test/test_bug_regression.py",
line 271, in test_import_all_modules
load_source(fqn, path)
File
"/<<BUILDDIR>>/pyfai-0.20.0+dfsg1/.pybuild/cpython3_3.10_pyfai/build/pyFAI/test/test_bug_regression.py",
line 78, in load_source
spec.loader.exec_module(module)
File "<frozen importlib._bootstrap_external>", line 883, in exec_module
File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
File
"/<<BUILDDIR>>/pyfai-0.20.0+dfsg1/.pybuild/cpython3_3.10_pyfai/build/pyFAI/utils/orderedset.py",
line 30, in <module>
class OrderedSet(collections.MutableSet):
AttributeError: module 'collections' has no attribute 'MutableSet'
```
In Ubuntu, the attached patch was applied to achieve the following:
* Fix FTBFS with python3.10, due to deprecated collections.MutableSets
Forwarded upstream: https://github.com/silx-kit/pyFAI/pull/1588
Thanks for considering the patch.
Cheers,
Lukas
-- System Information:
Debian Release: 11.0
APT prefers impish-updates
APT policy: (500, 'impish-updates'), (500, 'impish-security'), (500,
'impish'), (100, 'impish-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.13.0-20-generic (SMP w/4 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8),
LANGUAGE=de_DE:en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru pyfai-0.20.0+dfsg1/debian/patches/python3.10-compat.patch
pyfai-0.20.0+dfsg1/debian/patches/python3.10-compat.patch
--- pyfai-0.20.0+dfsg1/debian/patches/python3.10-compat.patch 1970-01-01
01:00:00.000000000 +0100
+++ pyfai-0.20.0+dfsg1/debian/patches/python3.10-compat.patch 2021-11-19
16:51:28.000000000 +0100
@@ -0,0 +1,40 @@
+Description: Fix collections.MutableSets compat with python3.10
+ collections.MutableSet was deprecated a long time ago and removed with
python3.10.
+ https://docs.python.org/3/whatsnew/3.10.html#removed
+ https://bugs.python.org/issue37324
+
+ Using the old class name leads to test failures such as this one:
+ ======================================================================
+ ERROR: test_import_all_modules
(pyFAI.test.test_bug_regression.TestBugRegression)
+ Try to import every single module in the package
+ ----------------------------------------------------------------------
+ Traceback (most recent call last):
+ File
"/<<BUILDDIR>>/pyfai-0.20.0+dfsg1/.pybuild/cpython3_3.10_pyfai/build/pyFAI/test/test_bug_regression.py",
line 286, in test_import_all_modules
+ raise err
+ File
"/<<BUILDDIR>>/pyfai-0.20.0+dfsg1/.pybuild/cpython3_3.10_pyfai/build/pyFAI/test/test_bug_regression.py",
line 271, in test_import_all_modules
+ load_source(fqn, path)
+ File
"/<<BUILDDIR>>/pyfai-0.20.0+dfsg1/.pybuild/cpython3_3.10_pyfai/build/pyFAI/test/test_bug_regression.py",
line 78, in load_source
+ spec.loader.exec_module(module)
+ File "<frozen importlib._bootstrap_external>", line 883, in exec_module
+ File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
+ File
"/<<BUILDDIR>>/pyfai-0.20.0+dfsg1/.pybuild/cpython3_3.10_pyfai/build/pyFAI/utils/orderedset.py",
line 30, in <module>
+ class OrderedSet(collections.MutableSet):
+ AttributeError: module 'collections' has no attribute 'MutableSet'
+Author: Lukas Märdian <sl...@ubuntu.com>
+Origin: vendor, Ubuntu
+Bug: https://github.com/silx-kit/pyFAI/pull/1588
+Forwarded: https://github.com/silx-kit/pyFAI/pull/1588
+Last-Update: 2021-11-19
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- pyfai-0.20.0+dfsg1.orig/pyFAI/utils/orderedset.py
++++ pyfai-0.20.0+dfsg1/pyFAI/utils/orderedset.py
+@@ -27,7 +27,7 @@
+ import collections
+
+
+-class OrderedSet(collections.MutableSet):
++class OrderedSet(collections.abc.MutableSet):
+
+ def __init__(self, iterable=None):
+ self.end = end = []
diff -Nru pyfai-0.20.0+dfsg1/debian/patches/series
pyfai-0.20.0+dfsg1/debian/patches/series
--- pyfai-0.20.0+dfsg1/debian/patches/series 2021-09-19 13:57:57.000000000
+0200
+++ pyfai-0.20.0+dfsg1/debian/patches/series 2021-11-19 16:51:28.000000000
+0100
@@ -6,3 +6,4 @@
0006-fix-a-couple-of-test-failing-with-i386.patch
0007-cleaner-test.patch
0008-tunning.patch
+python3.10-compat.patch
--- End Message ---
--- Begin Message ---
Source: pyfai
Source-Version: 0.20.0+dfsg1-4.1
Done: Stefano Rivera <stefa...@debian.org>
We believe that the bug you reported is fixed in the latest version of
pyfai, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1000...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stefano Rivera <stefa...@debian.org> (supplier of updated pyfai package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 22 Nov 2021 22:01:51 -0400
Source: pyfai
Architecture: source
Version: 0.20.0+dfsg1-4.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers
<debian-science-maintain...@lists.alioth.debian.org>
Changed-By: Stefano Rivera <stefa...@debian.org>
Closes: 1000204
Changes:
pyfai (0.20.0+dfsg1-4.1) unstable; urgency=medium
.
* Non-maintainer upload.
* Patch: Python 3.10 support, thanks Lukas Märdian. (Closes: #1000204)
Checksums-Sha1:
636aa14f4fcaf82ab2fc0414179bffd3fb1f436e 2099 pyfai_0.20.0+dfsg1-4.1.dsc
22559465523aa92a1e29e5615702218d552ce2a6 33736
pyfai_0.20.0+dfsg1-4.1.debian.tar.xz
32c322855165f1f72464e01ddd0ce3b6b9cf8524 11665
pyfai_0.20.0+dfsg1-4.1_source.buildinfo
Checksums-Sha256:
bce70f9feb9abc838e08ee47dcc78a9920711722a96d21dbe873cdfab8ff5dc0 2099
pyfai_0.20.0+dfsg1-4.1.dsc
d4b84d88abb5fca6c2c2260d9974ec45d244d8ae7cb71cce6d1e3ce78fa8e2c0 33736
pyfai_0.20.0+dfsg1-4.1.debian.tar.xz
990faf3ec0fa1af488db3976861dd583c47cf86f1b2e478a8d2b2eb36b461f00 11665
pyfai_0.20.0+dfsg1-4.1_source.buildinfo
Files:
f3a1a8bec333945b3aabcb6c604a6bdb 2099 science optional
pyfai_0.20.0+dfsg1-4.1.dsc
6f48e0dade83c7864ca7c8a78d0ce7c0 33736 science optional
pyfai_0.20.0+dfsg1-4.1.debian.tar.xz
c78a661549d16f018bd473c22cd4197b 11665 science optional
pyfai_0.20.0+dfsg1-4.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iIoEARYKADIWIQTumtb5BSD6EfafSCRHew2wJjpU2AUCYZxLwBQcc3RlZmFub3JA
ZGViaWFuLm9yZwAKCRBHew2wJjpU2IxeAQC4tkn/N2OakJbOasLi7ow50QzU/49J
0IfI46n4NY+kRwD/cLoV7CQwDpKJMyXth75s4HsFOwKsTM7FyO7YHjmgzwk=
=Ld/i
-----END PGP SIGNATURE-----
--- End Message ---
