Your message dated Fri, 31 Dec 2021 11:33:57 +0000
with message-id <e1n3gax-0000jy...@fasolo.debian.org>
and subject line Bug#1000784: fixed in php8.1 8.1.1-3
has caused the Debian Bug report #1000784,
regarding php8.1: does not trap errors from dtrace
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1000784: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1000784
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: php8.1
Version: 8.1.0-1
Severity: serious
Tags: patch
Justification: policy 4.6
When dtrace fails, the build system continues anyway. Such behaviour is
in violation with policy section 4.6 and thus justifies a
release-critical bug report. The actual issue resides in build/php.m4
line 2391 and following:
| $ac_bdir[$]ac_hdrobj: $abs_srcdir/$ac_provsrc
| CFLAGS="\$(CFLAGS_CLEAN)" dtrace -h -C -s $ac_srcdir[$]ac_provsrc -o
\$[]@.bak && \$(SED) -e 's,PHP_,DTRACE_,g' \$[]@.bak > \$[]@
The dtrace call is separated from the sed invocation using &&. While the
combination of "false && true" results in a non-zero exit, this does not
terminate the shell even with -e set. See the following example:
$ sh -c "set -e; false && true; echo huh"
huh
$
As such, a dtrace failures is swallowed and this causes the policy
violation. To fix this, one can invoke the two commands separately:
| $ac_bdir[$]ac_hdrobj: $abs_srcdir/$ac_provsrc
| CFLAGS="\$(CFLAGS_CLEAN)" dtrace -h -C -s $ac_srcdir[$]ac_provsrc -o
\$[]@.bak
| \$(SED) -e 's,PHP_,DTRACE_,g' \$[]@.bak > \$[]@
I'm attaching a patch for your convenience.
Helmut
--- php8.1-8.1.0.orig/build/php.m4
+++ php8.1-8.1.0/build/php.m4
@@ -2389,7 +2389,8 @@
$abs_srcdir/$ac_provsrc:;
$ac_bdir[$]ac_hdrobj: $abs_srcdir/$ac_provsrc
- CFLAGS="\$(CFLAGS_CLEAN)" dtrace -h -C -s $ac_srcdir[$]ac_provsrc -o \$[]@.bak && \$(SED) -e 's,PHP_,DTRACE_,g' \$[]@.bak > \$[]@
+ CFLAGS="\$(CFLAGS_CLEAN)" dtrace -h -C -s $ac_srcdir[$]ac_provsrc -o \$[]@.bak
+ \$(SED) -e 's,PHP_,DTRACE_,g' \$[]@.bak > \$[]@
\$(PHP_DTRACE_OBJS): $ac_bdir[$]ac_hdrobj
--- End Message ---
--- Begin Message ---
Source: php8.1
Source-Version: 8.1.1-3
Done: Ondřej Surý <ond...@debian.org>
We believe that the bug you reported is fixed in the latest version of
php8.1, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1000...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ondřej Surý <ond...@debian.org> (supplier of updated php8.1 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 31 Dec 2021 10:25:19 +0100
Source: php8.1
Architecture: source
Version: 8.1.1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian PHP Maintainers <team+pkg-...@tracker.debian.org>
Changed-By: Ondřej Surý <ond...@debian.org>
Closes: 1000784
Changes:
php8.1 (8.1.1-3) unstable; urgency=medium
.
* Fail the build when the dtrace call fails (Closes: #1000784)
Checksums-Sha1:
623d7c585d9301457774941b56ca54f412e0100d 5684 php8.1_8.1.1-3.dsc
3afef8d536e24adf8df9dd78ee2affff7fb771eb 11728680 php8.1_8.1.1.orig.tar.xz
91dd5bcce3579791885572adabd31a84f6dc5a4b 833 php8.1_8.1.1.orig.tar.xz.asc
f37e5ee9f2524c4d6fd8dcc9ad409ad8de4c3f94 65776 php8.1_8.1.1-3.debian.tar.xz
62432c9b5a30fabd8acf6c101984526069a31db8 31710 php8.1_8.1.1-3_amd64.buildinfo
Checksums-Sha256:
bcd5208d32e96a21d5f75dc316298ea1d1127def55e92e4e9dbb4ea44b435e6e 5684
php8.1_8.1.1-3.dsc
33c09d76d0a8bbb5dd930d9dd32e6bfd44e9efcf867563759eb5492c3aff8856 11728680
php8.1_8.1.1.orig.tar.xz
0edc73bfc9b94f638d1d33c0ff8edad4958ef64abe0fbe67f9c94ef34857da06 833
php8.1_8.1.1.orig.tar.xz.asc
1de86ca5fb62615596226b3cf6b1f7bc3fda76fac7e12ac37e372e09891bdbf3 65776
php8.1_8.1.1-3.debian.tar.xz
51ff5931ea6a7e546e03a83c5738f3f95d49ab5f6501d304da7d7f295f617c1c 31710
php8.1_8.1.1-3_amd64.buildinfo
Files:
60303b5d03bf36ec666289fafe2fd284 5684 php optional php8.1_8.1.1-3.dsc
a0cd96c783b1700e5ebf1ebfd1454f80 11728680 php optional php8.1_8.1.1.orig.tar.xz
302ae60bd112c7c8e0fa98506ea4d4db 833 php optional php8.1_8.1.1.orig.tar.xz.asc
0627f2872f49c8f27a71330db389914e 65776 php optional
php8.1_8.1.1-3.debian.tar.xz
ff0984cbbf96f15ce061ec8164fde214 31710 php optional
php8.1_8.1.1-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEw2Gx4wKVQ+vGJel9g3Kkd++uWcIFAmHO57FfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEMz
NjFCMUUzMDI5NTQzRUJDNjI1RTk3RDgzNzJBNDc3RUZBRTU5QzIACgkQg3Kkd++u
WcIRuQ//XH2hyqBYhgBlkIRXwnTaa/B2MdOLhKv/h6XXngvx7TzocLBhDCeoeJIV
dzV/HlUEAZlxk17LROSwwg3Pirm9QEsHHAnEisSY805MqUPbTBYYOYwvLMwWKKwg
buRhyaxeLAnyFzhU010+CaQl/tzNN4Te7QMO4sQdKH6FWVQAj7MZFEFUgtgVOyal
Z3HHNmP+TPHF1NknKZO5DwaAhKJDF+BZyKNEc4viqUdPHdv/ntCfN+gXydGzKRCU
1Y1TXglscAbOl/kdFNRr3DxcapAdx6VhOaoG5bNa/S9yln+tLTcF/tDZ4jKpAToX
hUMcVhLEVhhp0Q/rFtrRp0g9GvbmvK+qnxUe3ETpho6ozdt5HP6gkRf/u6M0a0FH
FbgY1Vu5CDMj/lcSoKk2gl+ZvNovxFaCzyVN2NicwJ0Xo+20/t2G4bfoCRiJvUc3
89TIJvs3tfmZdw4rroonPx3FIA7sXhbkiKRT8kcmCDUIPy1iN3qecmTbfGBXsuiQ
iV5YUncyPF2YqppaTAMJWIVosaff+mC8KWfE6IqoN1kOU3cEsY2lyjZTjhh/cfWB
16/MorAu2im/56b8Vfd/waeAwrGGGI9M976JNG+uaOPAaFvl72pzt/3NQwpFoOaZ
Afjz9IMYl3ma/awhuOi10cuZWnf0D1hMrpIe79dcnnJJttc86WE=
=9LT1
-----END PGP SIGNATURE-----
--- End Message ---
